From: Christian Hesse <list@eworm.de>
To: Loïc <lagiraudiere+cgit@free.fr>
Cc: cgit@lists.zx2c4.com
Subject: Re: Enhancement request : ui-blob: Make the target line of a link, visually identifiable.
Date: Mon, 15 Apr 2024 10:45:35 +0200 [thread overview]
Message-ID: <20240415104535.3d985290@leda.eworm.net> (raw)
In-Reply-To: <9fa56309-2907-4d01-a811-f438189dee8d@free.fr>
[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]
Loïc <lagiraudiere+cgit@free.fr> on Sun, 2024/04/14 23:56:
> Le 10/04/2024 à 15:29, Christian Hesse a écrit :
> > Loïc <lagiraudiere+cgit@free.fr> on Sat, 2024/02/03 18:20:
> >> Hi all,
> >>
> >> When I create a reference to a precise line in a file (for instance a
> >> hyperlink to "https://git.zx2c4.com/cgit/tree/cgit.css#n321" ), I miss a
> >> visual feedback, on the line I want to highlight.
> >>
> >> To implement this feature, I suggest to add a curved arrow ahead of the
> >> line number.
> >> That could be done by adding the following stylesheet to cgit.css
> >>
> >> div#cgit table.blob td.linenumbers a:target:before {color:
> >> red;content: "\2BA9";}
> > I really like that functionality, though the curved arrow is really
> > inconspicuous. Wondering if something like "large red circle" (or "large
> > black circle", colored in red) would be a better match...
>
> Unfortunately, the size is constrained by the underlying font.
Ah sure... Experience may differ depending on font.
> Initially, I searched for a character like "BLACK RIGHT POINTING
> BACKHAND INDEX" or "LINK SYMBOL", but it was even smaller. I also tried
> to change the font size but it didn't produce a good result either since
> it changes the line height.
>
> So, feel free to change the mark to something more convenient. The
> "large black circle" (\2B24), colored in red seems fine. (I prefer the
> "BLACK LARGE CIRCLE" colored in red over the "LARGE RED CIRCLE" because
> it makes it easier to change the color)
After all Jason has to decide...
Let's hope we will see any activity soon.
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-04-15 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 17:20 Loïc
2024-02-03 20:20 ` Christian Hesse
2024-04-10 13:29 ` Christian Hesse
2024-04-14 21:56 ` Loïc
2024-04-15 8:45 ` Christian Hesse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415104535.3d985290@leda.eworm.net \
--to=list@eworm.de \
--cc=cgit@lists.zx2c4.com \
--cc=lagiraudiere+cgit@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).