From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) by inbox.vuxu.org (Postfix) with ESMTP id 5086E20285 for ; Sun, 4 Aug 2024 20:46:00 +0200 (CEST) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 18749475; Sun, 4 Aug 2024 18:45:49 +0000 (UTC) Received: from mail.kasad.com (mail.kasad.com [140.82.7.10]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id d36c177a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 4 Aug 2024 18:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kasad.com; i=@kasad.com; q=dns/txt; s=mail; t=1722797147; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : from; bh=18skb8PfKC3qW/J/dAqRJrV035IQUWTGe0+422TeoSo=; b=gPVt3UyqeWaBxyd5Lt5ifksejb777wAohgTznri7ruyKy3irM0sgLo3EFvNAEqLVFXBWm KBJJP6dF2AuJ3/frtlEKolL1UFJpglVlfEs5oKgMgDBfUYbfYMJWQNxfXeFPu8vQZjcpgI+ 5BT+U9bJJRzg8yxADXtHb509aQB3na/v+PIyPPtgQdY4uXZ+Du4gf8fHaJMb57/Hrw995U2 +C7BF2t0XyudgL1AYB7HmV/uTZfcoaldkzM0if4xFnoVAGSmx3CjwDMluwGk2Ciue8sJaFe 6t4w9OGz4IVAQHBScXWO8qt6dpin7fiiRrvroWqIBNNmkRxPkQyauJya+UJw== Received: from Bagel.hsd1.ca.comcast.net.net (unknown [IPv6:2601:644:8301:e800:19d:b583:c65f:e3ba]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail.kasad.com (Postfix) with ESMTPSA id 7F49920190; Sun, 4 Aug 2024 14:45:46 -0400 (EDT) From: Kian Kasad To: cgit@lists.zx2c4.com Cc: dannftk@yandex.ru, Kian Kasad Subject: [PATCH v2] Fix error caused by missing parameter name Date: Sun, 4 Aug 2024 11:43:57 -0700 Message-ID: <20240804184459.84613-3-kian@kasad.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <65a07ff0-48b8-43d9-914e-adfc217f0858@yandex.ru> References: <65a07ff0-48b8-43d9-914e-adfc217f0858@yandex.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" This fixes an error which was introduced by 2f50b47c72cbc4270bbd12ae7f520486d5f42736. Git added a new argument to config_fn_t, and it was added to gitconfig_config(), but not named. This causes compile warnings/errors. This commit fixes that by naming the new parameter, and marking it unused. --- The attribute used here is specific to GCC and Clang, but we're already using non-standard features like the memrchr() function, so this seems like it isn't a problem. scan-tree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scan-tree.c b/scan-tree.c index 84da86e..8858b74 100644 --- a/scan-tree.c +++ b/scan-tree.c @@ -54,7 +54,8 @@ static void scan_tree_repo_config(const char *name, const char *value) config_fn(repo, name, value); } -static int gitconfig_config(const char *key, const char *value, const struct config_context *, void *cb) +static int gitconfig_config(const char *key, const char *value, + const __attribute__((unused)) struct config_context *ctx, void *cb) { const char *name; -- 2.46.0