From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 10114 invoked from network); 5 Jan 2023 23:15:04 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 5 Jan 2023 23:15:04 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 5235cfcc; Thu, 5 Jan 2023 23:14:47 +0000 (UTC) Return-Path: Received: from mail.kasad.com (mail.kasad.com [2001:19f0:5:46cc:5400:2ff:fed9:9eba]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id ba8c86fc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 5 Jan 2023 23:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kasad.com; i=@kasad.com; q=dns/txt; s=mail; t=1672960485; h=message-id : subject : from : to : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version : from; bh=Daj0Ct9zQbieW8Wa6pS2V9Bji825LbXVQVoO4h1Y/HY=; b=eqos5ZnbdAfYCxzzKGSUGGUxsD3XAreEbobFbkdv0cbjHI43D55QHDoV5BJzkt1b0/lxx I3Qwn7rV+BYu18sse/h+MizdUUYUChCeIYFWUERyBvEc1MrX5+6orvyEHk2z4tcAt626I7P 3vlaTa2SAXffkC7QH77urxzLrpkUeEsFhUz5BgCrEspT4KnKa4K1nkHQgqPUgu8ZJQrn/lQ 1zuLqwVKA6F4hU1fnAfWQzTR7f1UM9xNktoeUZPJULrDYOpTFxrPN83stjXrHCnPdzq1kV6 cMvScsp0AKtgwi/2DD+F9hGFre478g27ugOM9yo3Um708ZTtOpbPdEGQuy+g== Received: from [10.0.0.37] (c-73-93-113-167.hsd1.ca.comcast.net [73.93.113.167]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by mail.kasad.com (Postfix) with ESMTPSA id 3F1F22211F for ; Thu, 5 Jan 2023 15:14:45 -0800 (PST) Message-ID: <276a46560391a10194d808f6631b0c8612f0741e.camel@kasad.com> Subject: Follow-up: User-configurable log graph option From: Kian Kasad To: cgit@lists.zx2c4.com Date: Thu, 05 Jan 2023 15:14:42 -0800 In-Reply-To: <20211230210820.3ncgngexbbhlpbdq@frisbee.local> References: <20210218223126.yrgfjni73fi4rvw4@frisbee> <20211230210820.3ncgngexbbhlpbdq@frisbee.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 MIME-Version: 1.0 X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" Hello cgit developers, Just over a year ago, I proposed a configurable "graph" option for the log page. The idea was met with positive feedback, but when I proposed my implementation I never heard back. So I'm trying again in hopes that I can get a response. It would be nice if this was merged into the upstream so I don't have to maintain my fork, but if the way I've chosen to go about it isn't desirable, then I understand. But even in the latter case, I need a "no" so I know to stop trying to push this. The original conversation is below. I've also finished the implementation and am using it at https://git.kasad.com if you'd like to test it out. See here for my fork of cgit implementing this change: https://git.kasad.com/cgit/log/?h=3Dfeat%2Fgraph-page On Thu, 2021-12-30 at 13:08 -0800, Kian Kasad wrote: > On 21/02/19 12:22PM, John Keeping wrote: > > On Thu, Feb 18, 2021 at 02:31:26PM -0800, Kian Kasad wrote: > > > I'm using cgit on my website and I'm wondering if it's possible > > > to allow > > > the user (i.e. the person visiting the site) to choose whether or > > > not > > > the commit graph is displayed on the log page. > > >=20 > > > If this isn't currently possible, what do you think about adding > > > such > > > functionality? Maybe something like how the diff page lets the > > > user > > > choose between a "unified diff" and "ssdiff". > >=20 > > This sounds like a great new feature! > >=20 > > I think we still want to allow the administrator to turn the > > feature > > on/off but if it is permitted, then it makes sense to allow the end > > user > > to choose whether or not they want it enabled. >=20 > Following up on this as I'm finally getting around to implementing > this > feature. I'm not too familiar with CGit's codebase, so I think it > would > be easier to implement this as a separate "graph" page which is > identical to the log page except that it always displays a graph. >=20 > This graph page would only be shown in the navbar's tab list if the > "enable-commit-graph" option is set to "separate" in the > configuration. > If it is set to "combined" then the graph page will be disabled and > the > commit graph will be displayed on the log page as it currently is > when > the "enable-commit-graph" option is set to "1". >=20 > In order to maintain backwards compatibility, the value "1" could > also > be interpreted as the value "combined" since it has the same > functionality currently. >=20 > The value "none" (or "0" for backwards compatibility) would disable > the > graph page as well as disabling the commit graph on the log page. >=20 > I've already started working on this as I want it for my own CGit > site. > If this is something that the maintainer(s) want to integrate, I'll > send > patches when I'm done. --=20 Kian Kasad PGP 0x1715EEAA14DAEC1 kian@kasad.com (925) 871-9823