From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24852 invoked from network); 9 May 2022 14:57:48 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 9 May 2022 14:57:48 -0000 Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id f5f1b9a1; Mon, 9 May 2022 14:57:31 +0000 (UTC) Return-Path: Received: from sender4-op-o10.zoho.com (sender4-op-o10.zoho.com [136.143.188.10]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 4cef5d8e (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Mon, 9 May 2022 14:57:30 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1652108247; cv=none; d=zohomail.com; s=zohoarc; b=a2kEpPVKNSxOTpVsNVmf6EHAHSR1D4Xdf+2aN+j/WIa2VuVAn8s2yaNgh17cmlFJH6H2JQ/DE4cZuzb9/W3m87axGm2a4e8pMr3Gh9entYDcJH4x1enQl/LuayVErevv0I6GFGqHkb/6CQzt0chQKPwyy3iJwRYz3PqqGo5l0BM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652108247; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=uPDBC9jM3i0NBpcPKUMl1SSgwUoqvFwKY5G/M40Ik6U=; b=T8eBmV0JtuITpwp2ti49QvWV+rpoP/HJjIWFwu7LdRDrDw9KnLID6zefoj6n//j/KT+Mo0eOT0YFE6xkUqxY8HnAc9hJbBl/TMyBQSs2JzKmSJuzb5IwQrKVqcPVFLPXBpwKCwI7Ti5swvLUkQXq8UeBIYyOCkI6bh3NwLttEFU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=nilfm.cc; spf=pass smtp.mailfrom=nilix@nilfm.cc; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652108247; s=zoho; d=nilfm.cc; i=nilix@nilfm.cc; h=Date:Date:To:To:Cc:Cc:Subject:Subject:From:From:References:In-Reply-To:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=uPDBC9jM3i0NBpcPKUMl1SSgwUoqvFwKY5G/M40Ik6U=; b=AgOzT/Rq+4sLtypQofJP+yPiNrBN885zmfbnRX2rbee2UhgZxmKYB+WfjHueULFr ca0/SZTo8oHva+oF79P/gRgZXK7Y4cOf+R5ghAPgsTADqccz+ODi3u/ZpIQnSx+H5p9 XBM/LPWqC88Gc3R90zNioGLO+KvWJQBAdX+LE/sU= Received: from localhost (c-98-249-77-131.hsd1.nm.comcast.net [98.249.77.131]) by mx.zohomail.com with SMTPS id 1652108246269516.0296653977285; Mon, 9 May 2022 07:57:26 -0700 (PDT) Date: Mon, 09 May 2022 08:57:25 -0600 To: Max Resnick Cc: cgit@lists.zx2c4.com Subject: Re: [PATCH] add 'go-import' meta tag if in a repo From: Derek Stevens References: <20220109174549.qjdox4wuav3mxtci@ksatrya.siroonian.local> In-Reply-To: Message-Id: <29WX9UX8ZXQCA.3PBY77LL70O3H@ksatrya.nilfm.local> User-Agent: mblaze/1.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" I've been really busy with life lately so I don't mind if you take it on! Cheers, Derek "Max Resnick" wrote: > Hi are you going to complete this or would you care if I completed it?=20= >=20 > Thanks=20 > Max >=20 > On Sun, Jan 9, 2022, at 09:45, Derek Stevens wrote: > > Ok, I'll see about adding a config option and corresponding=20 > > documentation for this, as well as make sure that my indentation is=20 > > consistent. > > > > Thanks! > > Derek > > > > ------original message------ > > From: Jamie Couture > > Date: Sun, Jan 09, 2022 at 09:59:04AM MST > > > >> On Sat, Jan 08, 2022 at 04:55:59PM -0700, Derek Stevens wrote: > >> > Signed-off-by: Derek Stevens > >> > --- > >> > ui-shared.c | 3 +++ > >> > 1 file changed, 3 insertions(+) > >> >=20 > >> > diff --git a/ui-shared.c b/ui-shared.c > >> > index acd8ab5..0f57af6 100644 > >> > --- a/ui-shared.c > >> > +++ b/ui-shared.c > >> > @@ -785,6 +785,9 @@ void cgit_print_docstart(void) > >> > html_txt(ctx.page.title); > >> > html("\n"); > >> > htmlf("\n", cgit_vers= ion); > >> > + if (ctx.repo) > >> I recommend making this an optional feature people can opt-in and use.= =20 > >> Consider adding a configuration flag [1] and supporting documentation = [2], > >> allowing admins to turn a knob 'on' if they want to use this feature. > >>=20 > >> As John pointed out a minor nit: the leading whitespace should be tabs= ,=20 > >> whereas these lines are mixed tab-and-space.. > >>=20 > >> > + htmlf("\n", > >> > + host, cgit_rooturl(), ctx.repo->url, host, cgit_rooturl(), ctx= .repo->url); > >> > if (ctx.cfg.robots && *ctx.cfg.robots) > >> > htmlf("\n", ctx.cfg.robots);= > >> > html(" >> > --=20 > >> > 2.34.1 > >> >=20 > >>=20 > >> -- > >>=20 > >> [1] https://git.zx2c4.com/cgit/tree/cgit.c#n42 > >> [2] https://git.zx2c4.com/cgit/tree/cgitrc.5.txt > > > > > > > > ----- End forwarded message ----- > > > > Attachments: > > * signature.asc