List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH] tests: set TEST_OUTPUT_DIRECTORY to the CGit test directory
@ 2013-04-14 16:59 john
  0 siblings, 0 replies; only message in thread
From: john @ 2013-04-14 16:59 UTC (permalink / raw)


By default, Git's test suite puts the trash directories and test-results
directory into its own directory, not that containing the tests being
run.  This is less convenient for inspecting test failures, so set the
output directory to CGit's tests/ directory instead.

Note that there is currently a bug in Git whereby it will create the
trash directories in our tests/ directory regardless of the value of
TEST_OUTPUT_DIRECTORY, and then fail to remove them once the tests are
done.  This change does currently affect the location of the
test-results/ directory though.

Signed-off-by: John Keeping <john at keeping.me.uk>
---
I've posted a fix to the Git bug described in the last paragraph above
here: http://article.gmane.org/gmane.comp.version-control.git/221145

 tests/setup.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/setup.sh b/tests/setup.sh
index 81e7220..a573444 100755
--- a/tests/setup.sh
+++ b/tests/setup.sh
@@ -16,6 +16,7 @@
 # run_test 'repo summary' 'cgit_url "/foo" | tidy -e'
 
 : ${TEST_DIRECTORY=$(pwd)/../git/t}
+: ${TEST_OUTPUT_DIRECTORY=$(pwd)}
 TEST_NO_CREATE_REPO=YesPlease
 . "$TEST_DIRECTORY"/test-lib.sh
 
-- 
1.8.2.694.ga76e9c3.dirty





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-04-14 16:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-14 16:59 [PATCH] tests: set TEST_OUTPUT_DIRECTORY to the CGit test directory john

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).