From: mailings at hupie.com (Ferry Huberts)
Subject: [PATCH 2/2] tests: properly quote more variables
Date: Thu, 19 Jan 2012 22:08:41 +0100 [thread overview]
Message-ID: <4F188659.6090300@hupie.com> (raw)
In-Reply-To: <20120119205718.GB13613@blizzard>
On 19-01-12 21:57, Lukas Fleischer wrote:
> On Thu, Jan 19, 2012 at 08:24:15PM +0100, Ferry Huberts wrote:
>> From: Ferry Huberts<ferry.huberts at pelagic.nl>
>>
>> Signed-off-by: Ferry Huberts<ferry.huberts at pelagic.nl>
>> ---
>> tests/setup.sh | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/setup.sh b/tests/setup.sh
>> index 3b52de9..c54609c 100755
>> --- a/tests/setup.sh
>> +++ b/tests/setup.sh
>> @@ -18,11 +18,11 @@
>> unset CDPATH
>>
>> mkrepo() {
>> - name=$1
>> + name="$1"
>> count=$2
>> dir="$PWD"
>> test -d "$name"&& return
>> - printf "Creating testrepo %s\n" $name
>> + printf "Creating testrepo %s\n" "$name"
>
> Only this +/-1 line patch is needed - we don't need to quote right-hand
> side of assignments here (for details, read my reply to the other patch
> in this series).
>
yeah, but it won't hurt either.
and is more consistent
>> mkdir -p "$name"
>> cd "$name"
>> git init
>> @@ -114,8 +114,8 @@ run_test()
>> bug=1
>> shift
>> fi
>> - desc=$1
>> - script=$2
>> + desc="$1"
>> + script="$2"
>> test_count=$(expr $test_count + 1)
>> printf "\ntest %d: name='%s'\n" $test_count "$desc">>test-output.log
>> printf "test %d: eval='%s'\n" $test_count "$2">>test-output.log
>> --
>> 1.7.7.5
>>
>>
>> _______________________________________________
>> cgit mailing list
>> cgit at hjemli.net
>> http://hjemli.net/mailman/listinfo/cgit
>
> _______________________________________________
> cgit mailing list
> cgit at hjemli.net
> http://hjemli.net/mailman/listinfo/cgit
--
Ferry Huberts
next prev parent reply other threads:[~2012-01-19 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 19:24 [PATCH 1/2] tests: handle paths with whitespace mailings
2012-01-19 19:24 ` [PATCH 2/2] tests: properly quote more variables mailings
2012-01-19 20:57 ` cgit
2012-01-19 21:08 ` mailings [this message]
2012-01-21 20:39 ` cgit
2012-01-19 20:54 ` [PATCH 1/2] tests: handle paths with whitespace cgit
2012-01-29 15:29 ` [PATCH v2 " mailings
2012-01-29 15:29 ` [PATCH v2 2/2] tests: properly quote arguments to printf mailings
2012-03-06 22:26 ` [PATCH v2 1/2] tests: handle paths with whitespace mailings
2012-03-06 22:26 ` [PATCH v2 2/2] tests: properly quote arguments to printf mailings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F188659.6090300@hupie.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).