From: mailings at hupie.com (Ferry Huberts)
Subject: Image blobs should be printed as images instead of hexdumps
Date: Wed, 29 Feb 2012 12:39:30 +0100 [thread overview]
Message-ID: <4F4E0E72.5020906@hupie.com> (raw)
In-Reply-To: <4F4E0C42.70007@ape3000.com>
On 29-02-12 12:30, Lauri Niskanen wrote:
> Hi!
>
> Cgit currently prints a hexdump when you look at a image blob (as with
> any other binary blob). This might be a good way to show generic binary
> files, but I think images (at least png, jpg) should be shown as images.
>
> Example of the current behaviour:
> http://hjemli.net/git/cgit/tree/cgit.png
>
> I suggest that instead of the hexdump you would have HTML like this:
> <img src="http://hjemli.net/git/cgit/plain/cgit.png" />
>
> SVG images are not binaric so I would leave them printed as text.
>
> What do you think about this?
>
This is kind-of solved by my mime patch that's on wip.
Once Lars merges that into stable, you'll have it
http://hjemli.net/git/cgit/commit/?h=wip&id=d01c600c179593a53162a9d4e3040ecfc5078fdc
From what I understood from Lars is that files should always be shown
within cgit (non-plain) first, because some sites want to disable the
viewing of plain files.
--
Ferry Huberts
next prev parent reply other threads:[~2012-02-29 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 11:30 ape
2012-02-29 11:39 ` mailings [this message]
2012-03-01 9:56 ` ape
2012-03-01 13:34 ` mailings
2012-03-01 15:20 ` ape
2012-03-01 15:53 ` mailings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E0E72.5020906@hupie.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).