From mboxrd@z Thu Jan  1 00:00:00 1970
From: ape at ape3000.com (Lauri Niskanen)
Date: Thu, 01 Mar 2012 17:20:39 +0200
Subject: Image blobs should be printed as images instead of hexdumps
In-Reply-To: <4F4F7AD5.7080500@hupie.com>
References: <4F4E0C42.70007@ape3000.com> <4F4E0E72.5020906@hupie.com>
 <4F4F47BF.8000601@ape3000.com> <4F4F7AD5.7080500@hupie.com>
Message-ID: <4F4F93C7.5080307@ape3000.com>

On 01/03/12 15:34, Ferry Huberts wrote:
 > On 01-03-12 10:56, Lauri Niskanen wrote:
 >> On 29/02/12 13:39, Ferry Huberts wrote:
 >>>
 >>>
 >>> On 29-02-12 12:30, Lauri Niskanen wrote:
 >>>> Hi!
 >>>>
 >>>> Cgit currently prints a hexdump when you look at a image blob (as with
 >>>> any other binary blob). This might be a good way to show generic 
binary
 >>>> files, but I think images (at least png, jpg) should be shown as
 >>>> images.
 >>>>
 >>>> Example of the current behaviour:
 >>>> http://hjemli.net/git/cgit/tree/cgit.png
 >>>>
 >>>> I suggest that instead of the hexdump you would have HTML like this:
 >>>> <img src="http://hjemli.net/git/cgit/plain/cgit.png" />
 >>>>
 >>>> SVG images are not binaric so I would leave them printed as text.
 >>>>
 >>>> What do you think about this?
 >>>>
 >>>
 >>>
 >>> This is kind-of solved by my mime patch that's on wip.
 >>> Once Lars merges that into stable, you'll have it
 >>>
 >>> 
http://hjemli.net/git/cgit/commit/?h=wip&id=d01c600c179593a53162a9d4e3040ecfc5078fdc
 >>>
 >>>
 >>>
 >>>
 >>>
 >>> From what I understood from Lars is that files should always be shown
 >>> within cgit (non-plain) first, because some sites want to disable the
 >>> viewing of plain files.
 >>
 >> Thanks, but how does that patch solve my problem? Yeah, we probably need
 >> the mimetype information so that we know which files are images, but I
 >> don't see any code that would show images as <img>-tags instead of a
 >> hexdump.
 >>
 >
 >
 > from the page you mention, you can click the 'plain' link (if it's
 > enabled).
 >
 > That will send the file to you with the most appropriate mime-type.

Yeah. I've been using that, and it works just fine. But I really wanted 
something like this:
   http://x.ape3000.com/projects/cgit/cgit.png.htm

instead of this:
   http://hjemli.net/git/cgit/tree/cgit.png

There would be two main benefits from this. Firstly, it would be easier 
and faster to look at the actual image. Secondly, there would be a 
reason for not generating and showing a hexdump. The hexdump for an 
image seems to be mostly useless, and most people want to see the image 
when they click the file on the tree view.

Just to give more examples, I think GitHub has managed to solve this 
quite nicely:
   https://github.com/metajack/cgit/blob/master/cgit.png

-- 
Ape <Lauri Niskanen>