From mboxrd@z Thu Jan 1 00:00:00 1970 From: mailings at hupie.com (Ferry Huberts) Date: Wed, 04 Apr 2012 19:07:18 +0200 Subject: [PATCH v2 1/1] syntax-highlight: when the file has no extension, assume text In-Reply-To: <20120404165840.GA2090@blizzard> References: <1333556102-11560-1-git-send-email-mailings@hupie.com> <20120404165840.GA2090@blizzard> Message-ID: <4F7C7FC6.9090402@hupie.com> On 04-04-12 18:58, Lukas Fleischer wrote: > On Wed, Apr 04, 2012 at 06:15:02PM +0200, Ferry Huberts wrote: >> From: Ferry Huberts >> >> There are 2 situations: >> 1- empty extension: assuming text is better than highlight >> producing no output because of a missing argument. >> 2- no extension at all: assuming text is better than setting >> the extension to the filename, which is what now happens. >> >> Signed-off-by: Ferry Huberts >> --- >> filters/syntax-highlighting.sh | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/filters/syntax-highlighting.sh b/filters/syntax-highlighting.sh >> index 5fcc9c9..8b09180 100755 >> --- a/filters/syntax-highlighting.sh >> +++ b/filters/syntax-highlighting.sh >> @@ -39,6 +39,9 @@ >> BASENAME="$1" >> EXTENSION="${BASENAME##*.}" >> >> +[ "${BASENAME}" == "${EXTENSION}" ]&& EXTENSION=txt > > There is no "==" in POSIX shell/test(1). This should probably be a > single equal sign ("="). > >> +[ -z "${EXTENSION}" ]&& EXTENSION=txt >> + >> # map Makefile and Makefile.* to .mk >> [ "${BASENAME%%.*}" == "Makefile" ]&& EXTENSION=mk >> it appears there is, or (if there is not) the line above also doesn't work (that line has been in since 56522eb, 19-11-2009) -- Ferry Huberts