* [PATCH] Print submodule revision next to submodule link [not found] <CA+_rJqTj5qD98+2Qg81V+ofW118tCNYbv-0q1rpmnx_48WKHKg@mail.gmail.com> @ 2013-03-01 9:53 ` stfnmd 2013-03-01 9:58 ` stfnmd ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: stfnmd @ 2013-03-01 9:53 UTC (permalink / raw) Hi, the attached patch simply prints the revision SHA1 of a submodule right next to the submodule link (on the tree view page). I find this quite useful as it allows a quick and easy overview of the module revisions. Regards --stfn ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Print submodule revision next to submodule link 2013-03-01 9:53 ` [PATCH] Print submodule revision next to submodule link stfnmd @ 2013-03-01 9:58 ` stfnmd 2013-03-01 10:43 ` mailings 2013-03-01 11:14 ` Jason 2013-03-02 15:31 ` Jason 2 siblings, 1 reply; 7+ messages in thread From: stfnmd @ 2013-03-01 9:58 UTC (permalink / raw) Please see https://github.com/stfnm/cgit/commit/49a93ca757d8f6d5122477d404eab1f88efbb1ee.patch ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Print submodule revision next to submodule link 2013-03-01 9:58 ` stfnmd @ 2013-03-01 10:43 ` mailings 2013-03-01 10:50 ` nobody 0 siblings, 1 reply; 7+ messages in thread From: mailings @ 2013-03-01 10:43 UTC (permalink / raw) submit the patch on the mailing list so that people can see and review it right here. On 01/03/13 10:58, stfn wrote: > Please see > > https://github.com/stfnm/cgit/commit/49a93ca757d8f6d5122477d404eab1f88efbb1ee.patch > > _______________________________________________ > cgit mailing list > cgit at hjemli.net > http://hjemli.net/mailman/listinfo/cgit > -- Ferry Huberts ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Print submodule revision next to submodule link 2013-03-01 10:43 ` mailings @ 2013-03-01 10:50 ` nobody 2013-03-01 10:54 ` mailings 0 siblings, 1 reply; 7+ messages in thread From: nobody @ 2013-03-01 10:50 UTC (permalink / raw) On 03/01/2013 11:43 AM, Ferry Huberts wrote: > submit the patch on the mailing list so that people can see and review > it right here. Another thing I am wondering about: is there a consensus on how to handle submissions without a real name? -Christian ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Print submodule revision next to submodule link 2013-03-01 10:50 ` nobody @ 2013-03-01 10:54 ` mailings 0 siblings, 0 replies; 7+ messages in thread From: mailings @ 2013-03-01 10:54 UTC (permalink / raw) yeah. reject On 01/03/13 11:50, Christian Franke wrote: > On 03/01/2013 11:43 AM, Ferry Huberts wrote: >> submit the patch on the mailing list so that people can see and review >> it right here. > > Another thing I am wondering about: is there a consensus on how to > handle submissions without a real name? > > -Christian > > _______________________________________________ > cgit mailing list > cgit at hjemli.net > http://hjemli.net/mailman/listinfo/cgit > -- Ferry Huberts ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Print submodule revision next to submodule link 2013-03-01 9:53 ` [PATCH] Print submodule revision next to submodule link stfnmd 2013-03-01 9:58 ` stfnmd @ 2013-03-01 11:14 ` Jason 2013-03-02 15:31 ` Jason 2 siblings, 0 replies; 7+ messages in thread From: Jason @ 2013-03-01 11:14 UTC (permalink / raw) Hi Stfn, I'm about to get on plane, so I'll pull your patch and review it during the flight. Thanks for the submission. Looks like folks on this list find issue with anonymous commit authors. I've never had an issue myself with doing this for security or reverse engineering related projects, and I'll likely be happy with including it in my repo for cgit, but in order to quell potential controversy and debate, would you mind sending it with your real name? We generally like git-send-email / git-format-patch so reviewers can reply inline, but for something so small, so long as it's not a githubpullrequesteratorsizer, it'll pass. Jason -- Sent from my telephone.On 3/1/13 10:53 stfn wrote: Hi, the attached patch simply prints the revision SHA1 of a submodule right next to the submodule link (on the tree view page). I find this quite useful as it allows a quick and easy overview of the module revisions. Regards --stfn ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Print submodule revision next to submodule link 2013-03-01 9:53 ` [PATCH] Print submodule revision next to submodule link stfnmd 2013-03-01 9:58 ` stfnmd 2013-03-01 11:14 ` Jason @ 2013-03-02 15:31 ` Jason 2 siblings, 0 replies; 7+ messages in thread From: Jason @ 2013-03-02 15:31 UTC (permalink / raw) On Fri, Mar 1, 2013 at 4:53 AM, stfn <stfnmd at gmail.com> wrote: > the attached patch simply prints the revision SHA1 of a submodule > right next to the submodule link (on the tree view page). > I find this quite useful as it allows a quick and easy overview of > the module revisions. Very useful and still subtle. Merged wholesale: http://git.zx2c4.com/cgit/commit/?id=c0a92e82da3063efc230538ba109ff95aa59589a ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-02 15:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CA+_rJqTj5qD98+2Qg81V+ofW118tCNYbv-0q1rpmnx_48WKHKg@mail.gmail.com>
2013-03-01 9:53 ` [PATCH] Print submodule revision next to submodule link stfnmd
2013-03-01 9:58 ` stfnmd
2013-03-01 10:43 ` mailings
2013-03-01 10:50 ` nobody
2013-03-01 10:54 ` mailings
2013-03-01 11:14 ` Jason
2013-03-02 15:31 ` Jason
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).