From: mailings at hupie.com (Ferry Huberts)
Subject: [PATCH v2 2/2] Makefile: get the git version from the submodule
Date: Mon, 04 Mar 2013 14:49:49 +0100 [thread overview]
Message-ID: <5134A67D.7010806@hupie.com> (raw)
In-Reply-To: <CAFXTnz59Z+qsW=2=378rb_yoO+UxJNQyvox-x6Y1JR6G74bbGQ@mail.gmail.com>
On 04/03/13 14:38, Lars Hjemli wrote:
> On Mon, Mar 4, 2013 at 2:26 PM, Ferry Huberts <mailings at hupie.com> wrote:
>> diff --git a/Makefile b/Makefile
>> index 118a2c9..6d834ed 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -14,8 +14,8 @@ htmldir = $(docdir)
>> pdfdir = $(docdir)
>> mandir = $(prefix)/share/man
>> SHA1_HEADER = <openssl/sha.h>
>> -GIT_VER = 1.7.12.4
>> -GIT_URL = https://github.com/git/git/archive/v$(GIT_VER).tar.gz
>> +GIT_VER = $(shell git submodule status git | sed -r 's/^[^0-9a-fA-F]*([0-9a-fA-F]*).*/\1/')
>> +GIT_URL = https://github.com/git/git/archive/$(GIT_VER).tar.gz
>
> Please don't do this - the GIT_URL is used when building from a cgit
> tarball, in which case `git submodule` wlll fail...
>
no problem, now we just need a reminder somewhere that the makefile also
has to be updated ;-)
--
Ferry Huberts
next prev parent reply other threads:[~2013-03-04 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 13:26 [PATCH v2 1/2] Makefile: update GIT_VER to use v1.7.12.4 mailings
2013-03-04 13:26 ` [PATCH v2 2/2] Makefile: get the git version from the submodule mailings
2013-03-04 13:34 ` john
2013-03-04 14:26 ` Jason
2013-03-04 13:38 ` hjemli
2013-03-04 13:49 ` mailings [this message]
2013-03-04 13:56 ` hjemli
2013-03-04 14:22 ` Jason
2013-03-04 14:20 ` [PATCH v2 1/2] Makefile: update GIT_VER to use v1.7.12.4 Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5134A67D.7010806@hupie.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).