Subject: [PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION changes
Date: Thu, 07 Mar 2013 10:49:53 +0100 [thread overview]
Message-ID: <513862C1.2000001@necoro.eu> (raw)
In-Reply-To: <20130307090711.GX7738@serenity.lan>
Am 07.03.2013 10:07, schrieb John Keeping:
> On Thu, Mar 07, 2013 at 09:16:50AM +0100, Lukas Fleischer wrote:
>> On Thu, Mar 07, 2013 at 09:03:11AM +0100, Ren? Neumann wrote:
>>>> +# Only cgit.c reference CGIT_VERSION so we only rebuild its objects when the
>>>> +# version changes.
>>>> +CGIT_VERSION_OBJS := $(addprefix $(CGIT_PREFIX),cgit.o)
>>>> +$(CGIT_VERSION_OBJS): $(CGIT_PREFIX)VERSION
>>>> +$(CGIT_VERSION_OBJS): EXTRA_CPPFLAGS = \
>>>> + -DCGIT_VERSION='"$(CGIT_VERSION)"'
>>>
>>> Is the small gain (not rebuilding a couple of small C-files) worth this
>>> hassle? Because it sounds a bit like a maintenance nightmare: One more
>>> place to remember to put a file.
>
> It's not a couple of C files, it's *all* of the CGit C files.
Well, in my perspective, *all* of CGit C files _is_ 'a couple'.
> Exactly. We shouldn't ever need to use the #define'd CGIT_VERSION in
> more than one place.
That's a fair point.
- Ren?
next prev parent reply other threads:[~2013-03-07 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 21:22 [PATCH v3 0/4] Makefile improvements john
2013-03-06 21:22 ` [PATCH v3 1/4] Makefile: re-use Git's Makefile where possible john
2013-03-20 19:33 ` Jason
2013-03-06 21:22 ` [PATCH v3 2/4] ui-patch: use cgit_version not CGIT_VERSION john
2013-03-06 21:22 ` [PATCH v3 3/4] cgit.mk: don't rebuild everything if CGIT_VERSION changes john
2013-03-07 8:03 `
2013-03-07 8:16 ` cgit
2013-03-07 9:07 ` john
2013-03-07 9:49 ` [this message]
2013-03-06 21:22 ` [PATCH v3 4/4] cgit.mk: Use SHELL_PATH_SQ to run gen-version.sh john
2013-03-20 19:34 ` [PATCH v3 0/4] Makefile improvements Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513862C1.2000001@necoro.eu \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).