From mboxrd@z Thu Jan 1 00:00:00 1970 From: lists at necoro.eu (=?UTF-8?B?UmVuw6kgTmV1bWFubg==?=) Date: Sat, 20 Apr 2013 13:21:52 +0200 Subject: [PATCH v2 2/2] log: allow users to follow a file In-Reply-To: <63567740b5b2b2b79eafff7a00148ef8a7b71bad.1366452850.git.john@keeping.me.uk> References: <20130419075437.GD2278@serenity.lan> <63567740b5b2b2b79eafff7a00148ef8a7b71bad.1366452850.git.john@keeping.me.uk> Message-ID: <51727A50.3070401@necoro.eu> Awesome! Your patches work great over here. I'm so glad, I had not tried to implement this myself :) > For commits before the file has been renamed (i.e. that appear later in > the log list) we change the file path in the links from the log to point > to the old name; this means that links to commits always limit by the > path known to that commit. If we didn't do this we would need to walk > down the log diff'ing every commit whenever we want to show a commit. > The drawback is that the "Log" link in the top bar of such a page links > to the log limited by the old name, so it will only show pre-rename > commits. I consider this a reasonable trade-off since the "Back" button > still works and the log matches the path displayed in the top bar. I also think this is reasonable. When running into this issue, you usually already know what you are doing, so one might be surprised but not lost. - Ren?