From: stefan at sevenbyte.org (Stefan Tatschner)
Subject: RESEND: syntax-highlighting.py
Date: Thu, 09 Jan 2014 20:52:15 +0100 [thread overview]
Message-ID: <52CEFDEF.8040007@sevenbyte.org> (raw)
In-Reply-To: <CAHmME9qeP0XoocaAY4HGFvZo9HNp2J-zRe6ex-P1h32KcnMWNQ@mail.gmail.com>
Am 08.01.2014 17:28, schrieb Jason A. Donenfeld:
>> What do you want to de with the CSS definitions? Just put them into the
>> default cgit CSS file or maybe include it seperately?
>
> We already handle that on line 34 of [1], so no need to do anything
> differently. Please base your work off [1] generally.
>
> [1] http://git.zx2c4.com/cgit/tree/filters/syntax-highlighting.py
Actually I do not like this implementation of CSS output in the script.
In the final HTML output there is something like this:
<td class='lines'><pre><code><style>.highlight .hll { background-color:
#ffffcc }
.highlight { background: #ffffff; }
.highlight .c { color: #888888 } /* Comment */
.highlight .err { color: #a61717; background-color: #e3d2d2 }
[...]
</style><div class="highlight"><pre>
You see the CSS definitions for the synthax highlighting thing come
within a table within a pre within a code tag. I do not think this is
the right place for CSS definitions.
What do you think?
Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140109/f76b1af2/attachment.asc>
next prev parent reply other threads:[~2014-01-09 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52CD7ADF.2080903@sevenbyte.org>
2014-01-08 16:22 ` Fwd: " stefan
2014-01-08 16:28 ` Jason
2014-01-09 19:52 ` stefan [this message]
2013-11-04 20:46 syntax-highlighting.py stefan
2014-01-08 14:56 ` RESEND: syntax-highlighting.py stefan
2014-01-08 15:14 ` Jason
[not found] ` <CAHmME9p-89eXYBW0V-nn32XNrkFadFHD6r==qDjf9Pwk+jDNPg@mail.gmail.com>
2014-01-10 13:07 ` stefan
2014-01-10 16:19 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CEFDEF.8040007@sevenbyte.org \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).