From mboxrd@z Thu Jan  1 00:00:00 1970
From: stefan at sevenbyte.org (Stefan Tatschner)
Date: Thu, 09 Jan 2014 20:52:15 +0100
Subject: RESEND: syntax-highlighting.py
In-Reply-To: <CAHmME9qeP0XoocaAY4HGFvZo9HNp2J-zRe6ex-P1h32KcnMWNQ@mail.gmail.com>
References: <52CD7ADF.2080903@sevenbyte.org>	<52CD7B30.3010208@sevenbyte.org>
 <CAHmME9qeP0XoocaAY4HGFvZo9HNp2J-zRe6ex-P1h32KcnMWNQ@mail.gmail.com>
Message-ID: <52CEFDEF.8040007@sevenbyte.org>

Am 08.01.2014 17:28, schrieb Jason A. Donenfeld:
>> What do you want to de with the CSS definitions? Just put them into the
>> default cgit CSS file or maybe include it seperately?
> 
> We already handle that on line 34 of [1], so no need to do anything
> differently. Please base your work off [1] generally.
>
> [1] http://git.zx2c4.com/cgit/tree/filters/syntax-highlighting.py

Actually I do not like this implementation of CSS output in the script.
In the final HTML output there is something like this:

<td class='lines'><pre><code><style>.highlight .hll { background-color:
#ffffcc }
.highlight  { background: #ffffff; }
.highlight .c { color: #888888 } /* Comment */
.highlight .err { color: #a61717; background-color: #e3d2d2 }

[...]

</style><div class="highlight"><pre>

You see the CSS definitions for the synthax highlighting thing come
within a table within a pre within a code tag. I do not think this is
the right place for CSS definitions.

What do you think?

Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140109/f76b1af2/attachment.asc>