List for cgit developers and users
 help / color / mirror / Atom feed
From: bluewind at xinu.at (Florian Pritz)
Subject: RFE: .so filters
Date: Fri, 10 Jan 2014 21:56:32 +0100	[thread overview]
Message-ID: <52D05E80.4000800@xinu.at> (raw)
In-Reply-To: <20140110203652.GR7608@serenity.lan>

On 10.01.2014 21:36, John Keeping wrote:
>> Looks rather easy to slurp stdin (from http://www.lua.org/pil/21.1.html):
> 
> Interesting.  But I think it will be simpler from both side if the
> interface is just a function call

source_filter could potentially get a rather long input and might not
need it all at once. If it can processes input line by line or similar
it makes sense to support that by writing chunks rather than buffering
everything.

I believe we currently already buffer the file (ui-tree.c print_object()
buf variable) before calling the source_filter, but keeping the
possibility to change that later is good.

Also slurping is not really that much harder than writing the function
header so I don't see a benefit in adding buffering to the cgit code.

Last but not least, it keeps the interface between "exec" and "lua"
filters the same or at least rather similar. If you can call a lua
script as if it was execed (setting argv) that would make the handler
totally transparent, but faster.

> The only thing I'm not sure about is how the specification of the filter
> function works, given that I don't think we can call a complete Lua
> script as a function.  (I'm also assuming that the Lua script will be in
> an external file and not stored inline in the CGit config).

http://www.lua.org/pil/25.2.html


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140110/15c96233/attachment-0001.asc>


  reply	other threads:[~2014-01-10 20:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 21:34 Jason
2014-01-09 22:29 ` mailings
2014-01-09 22:58 ` john
2014-01-10  1:41   ` Jason
2014-01-10  2:11     ` Jason
2014-01-10  4:26       ` Jason
2014-01-10  9:06       ` john
2014-01-10 15:57         ` Jason
2014-01-10 17:12           ` bluewind
2014-01-10 17:20             ` john
2014-01-10 17:43               ` mricon
2014-01-10 18:00                 ` Jason
2014-01-10 18:00               ` Jason
2014-01-10 17:57             ` Jason
2014-01-10 20:03               ` bluewind
2014-01-10 20:11                 ` john
2014-01-10 20:25                   ` bluewind
2014-01-10 20:36                     ` john
2014-01-10 20:56                       ` bluewind [this message]
2014-01-11  2:37                         ` Jason
2014-01-11  2:34                 ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D05E80.4000800@xinu.at \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).