From mboxrd@z Thu Jan 1 00:00:00 1970 From: bluewind at xinu.at (Florian Pritz) Date: Mon, 13 Jan 2014 10:41:13 +0100 Subject: [PATCH 06/12] filter: add preliminary lua support In-Reply-To: <1389586279-23724-7-git-send-email-Jason@zx2c4.com> References: <1389586279-23724-1-git-send-email-Jason@zx2c4.com> <1389586279-23724-7-git-send-email-Jason@zx2c4.com> Message-ID: <52D3B4B9.30900@xinu.at> On 13.01.2014 05:11, Jason A. Donenfeld wrote: > Signed-off-by: Jason A. Donenfeld > --- > cgit.h | 2 +- > cgit.mk | 13 ++- > filter.c | 284 ++++++++++++++++++++++++++++++++++++++++++++++++--------------- All those *_lua_filter functions look rather self contained, maybe they should be split into filter_lua.c for readability? Also I'm not sure why documenting the filter and adding error reporting to totally new code go into separate commits. They are one logical change after all. As Lukas already said it's probably a lot better if you split the cleanup and moving-stuff-around into it's own patch. (Or merge it into "basic write hooking infrastructure" since you create that code there so it should be created at the correct place) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: OpenPGP digital signature URL: