From: mricon at kernel.org (Konstantin Ryabitsev)
Subject: [PATCH] ui-patch: Flush stdout after outputting data
Date: Wed, 11 Jun 2014 16:28:26 -0400 [thread overview]
Message-ID: <5398BBEA.8090002@kernel.org> (raw)
In-Reply-To: <e5d12dc466aa3b894c03871c42638dd9108c83a2.1402516882.git.john@keeping.me.uk>
On 11/06/14 04:01 PM, John Keeping wrote:
> Since the "html" functions use raw write(2) to STDIO_FILENO, we don't
> notice problems with most pages, but raw patches write using printf(3).
> This is fine if we're outputting straight to stdout since the buffers
> are flushed on exit, but we close the cache output before this, so the
> cached output ends up being truncated.
>
> Make sure the buffers are flushed when we finish outputting a patch so
> that we avoid this.
>
> No other UIs use printf(3) so we do not need to worry about them.
Confirming fix -- in production at kernel.org.
Thanks a ton for the lightning-speed turnaround.
Best,
--
Konstantin Ryabitsev
Senior Systems Administrator
Linux Foundation Collab Projects
Montr?al, Qu?bec
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140611/cb95e004/attachment.asc>
next prev parent reply other threads:[~2014-06-11 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 19:46 Cache bug: cached patches truncated to nearest 1024-byte boundary mricon
2014-06-11 20:01 ` [PATCH] ui-patch: Flush stdout after outputting data john
2014-06-11 20:28 ` mricon [this message]
2014-06-11 20:55 ` john
2014-06-28 13:59 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5398BBEA.8090002@kernel.org \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).