From mboxrd@z Thu Jan  1 00:00:00 1970
From: chris.burroughs at gmail.com (Chris Burroughs)
Date: Fri, 01 Aug 2014 14:06:11 -0400
Subject: commit-filter not being applied on log page
In-Reply-To: <20140801094429.GP26927@serenity.lan>
References: <53DA5247.9000600@gmail.com> <20140801094429.GP26927@serenity.lan>
Message-ID: <53DBD713.6030709@gmail.com>

On 08/01/2014 05:44 AM, John Keeping wrote:
> On Thu, Jul 31, 2014 at 10:27:19AM -0400, Chris Burroughs wrote:
>> I'm trying to write a commit-filter to hyperlink references to our bug
>> tracker.  It seems to work fine for commit detailed pages, but not at
>> all for the log view.  Since our developers often make brief messages
>> like "fixes #123' so getting the url in the log view is arguably more
>> useful than in the detail page.
>
> I think this is an issue of the cost of forking a filter process for
> each line in the log view.  Now that we have Lua filters that may not be
> so much of an issue, but I don't think we can just start using the
> source filter on the log view due to the impact that will have on people
> with an "exec" source-filter already configured.
>
> Perhaps we need to add a "log-filter" which you could configure to be
> the same as "source-filter" but which can be left blank for people whose
> links are normally in the body of the commit message.
>

I think a "log-filter" with the same API sounds good and fits my use 
case.  I'll take a stab at that after the owner-filter work.