From mboxrd@z Thu Jan 1 00:00:00 1970 From: chris.burroughs at gmail.com (Chris Burroughs) Date: Thu, 31 Jul 2014 10:27:19 -0400 Subject: commit-filter not being applied on log page Message-ID: <53DA5247.9000600@gmail.com> I'm trying to write a commit-filter to hyperlink references to our bug tracker. It seems to work fine for commit detailed pages, but not at all for the log view. Since our developers often make brief messages like "fixes #123' so getting the url in the log view is arguably more useful than in the detail page. For example if there was a hypothetical filter that turned v1.2.3 into v1.2.3 it would work on http://git.zx2c4.com/cgit/commit/?id=865afe0eb1b5e6485fe0f65472e6635266e393b1 but not http://git.zx2c4.com/cgit/log/ or http://git.zx2c4.com/cgit/log/?showmsg=1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Fri, 1 Aug 2014 10:44:29 +0100 Subject: commit-filter not being applied on log page In-Reply-To: <53DA5247.9000600@gmail.com> References: <53DA5247.9000600@gmail.com> Message-ID: <20140801094429.GP26927@serenity.lan> On Thu, Jul 31, 2014 at 10:27:19AM -0400, Chris Burroughs wrote: > I'm trying to write a commit-filter to hyperlink references to our bug > tracker. It seems to work fine for commit detailed pages, but not at > all for the log view. Since our developers often make brief messages > like "fixes #123' so getting the url in the log view is arguably more > useful than in the detail page. I think this is an issue of the cost of forking a filter process for each line in the log view. Now that we have Lua filters that may not be so much of an issue, but I don't think we can just start using the source filter on the log view due to the impact that will have on people with an "exec" source-filter already configured. Perhaps we need to add a "log-filter" which you could configure to be the same as "source-filter" but which can be left blank for people whose links are normally in the body of the commit message. From mboxrd@z Thu Jan 1 00:00:00 1970 From: chris.burroughs at gmail.com (Chris Burroughs) Date: Fri, 01 Aug 2014 14:06:11 -0400 Subject: commit-filter not being applied on log page In-Reply-To: <20140801094429.GP26927@serenity.lan> References: <53DA5247.9000600@gmail.com> <20140801094429.GP26927@serenity.lan> Message-ID: <53DBD713.6030709@gmail.com> On 08/01/2014 05:44 AM, John Keeping wrote: > On Thu, Jul 31, 2014 at 10:27:19AM -0400, Chris Burroughs wrote: >> I'm trying to write a commit-filter to hyperlink references to our bug >> tracker. It seems to work fine for commit detailed pages, but not at >> all for the log view. Since our developers often make brief messages >> like "fixes #123' so getting the url in the log view is arguably more >> useful than in the detail page. > > I think this is an issue of the cost of forking a filter process for > each line in the log view. Now that we have Lua filters that may not be > so much of an issue, but I don't think we can just start using the > source filter on the log view due to the impact that will have on people > with an "exec" source-filter already configured. > > Perhaps we need to add a "log-filter" which you could configure to be > the same as "source-filter" but which can be left blank for people whose > links are normally in the body of the commit message. > I think a "log-filter" with the same API sounds good and fits my use case. I'll take a stab at that after the owner-filter work. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason at zx2c4.com (Jason A. Donenfeld) Date: Tue, 23 Dec 2014 19:03:02 -0700 Subject: commit-filter not being applied on log page In-Reply-To: <53DBD713.6030709@gmail.com> References: <53DA5247.9000600@gmail.com> <20140801094429.GP26927@serenity.lan> <53DBD713.6030709@gmail.com> Message-ID: On Fri, Aug 1, 2014 at 12:06 PM, Chris Burroughs wrote: > > I think a "log-filter" with the same API sounds good and fits my use > case. I'll take a stab at that after the owner-filter work. > Ready now, when you are. -------------- next part -------------- An HTML attachment was scrubbed... URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: chris.burroughs at gmail.com (Chris Burroughs) Date: Mon, 05 Jan 2015 14:03:57 -0500 Subject: commit-filter not being applied on log page In-Reply-To: <20140801094429.GP26927@serenity.lan> References: <53DA5247.9000600@gmail.com> <20140801094429.GP26927@serenity.lan> Message-ID: <54AAE01D.3040508@gmail.com> On 08/01/2014 05:44 AM, John Keeping wrote: > On Thu, Jul 31, 2014 at 10:27:19AM -0400, Chris Burroughs wrote: >> I'm trying to write a commit-filter to hyperlink references to our bug >> tracker. It seems to work fine for commit detailed pages, but not at >> all for the log view. Since our developers often make brief messages >> like "fixes #123' so getting the url in the log view is arguably more >> useful than in the detail page. > > I think this is an issue of the cost of forking a filter process for > each line in the log view. Now that we have Lua filters that may not be > so much of an issue, but I don't think we can just start using the > source filter on the log view due to the impact that will have on people > with an "exec" source-filter already configured. > > Perhaps we need to add a "log-filter" which you could configure to be > the same as "source-filter" but which can be left blank for people whose > links are normally in the body of the commit message. > I started to implement a 'log-filter' but ran into some design problems: * My initial use case was to create a link for 'fixes #123' style commit messages. However, the entire log summary snippet is already wrapped in an to commit/?id=foo. I wouldn't want to loose that or make it uglier in service of convenience bug tracker links. Since html links can not be nested I'm not sure what options that leaves. * With showmsg=1, should the commit or log filter be used?