From: i at monkz.de (MonkZ)
Subject: cgit and symlinks
Date: Wed, 8 Mar 2017 12:38:38 +0100 [thread overview]
Message-ID: <5435925d-c258-4196-ce9b-d08348593624@monkz.de> (raw)
In-Reply-To: <20170306233525.GD2102@john.keeping.me.uk>
Am 07.03.2017 um 00:35 schrieb John Keeping:
> We can't reliably follow the link because there is no guarantee that the
> target lies within the repository and I don't know what we would output
> for the case where we can't display the target.
INADH (I'm not a dev here)
I would recommend to continue ignoring it or returning the blob, because
following symlinks (internally) might result - if not done carefully -
in directory traversal security issues. Maybe resolving a symlink to a
HTTP301 could work.
For the UI there might be a html-link (in a notification box "This is a
symlink that points to ...") to the symlink-destination below or above
the blob, to get a user via click to a file/directory.
Regards,
MonkZ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170308/1daf3f21/attachment.asc>
next prev parent reply other threads:[~2017-03-08 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 10:42 oliver+cgit
2017-03-06 23:35 ` john
2017-03-08 11:38 ` i [this message]
2017-03-08 12:30 ` john
2017-03-08 13:28 ` i
2017-03-09 0:15 ` john
2017-03-09 7:58 ` i
2017-03-12 14:18 ` john
2017-03-13 8:59 ` i
2017-03-21 4:56 ` dlcampbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5435925d-c258-4196-ce9b-d08348593624@monkz.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).