From: mricon at kernel.org (Konstantin Ryabitsev)
Subject: RFE: Show just diff summary
Date: Mon, 29 Dec 2014 15:09:55 -0500 [thread overview]
Message-ID: <54A1B513.2000304@kernel.org> (raw)
In-Reply-To: <CAHmME9rV0u5N7uEORLg7qG-EQkytapjLhOs=PVv2g8S7NGTXWg@mail.gmail.com>
On 23/12/14 09:30 PM, Jason A. Donenfeld wrote:
> Ahh yes, of course -- John has done it, and it's been merged
> here: ddfaef6bb28e697491b25bff5a7b260d44ce6ccf
Hi, all:
I actually had a chance to try it out now. It looks pretty nice, but has
an unintended downside in the sense that "dt=2" is sticky. E.g. for a
link like:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/?id=v3.19-rc2&id2=v3.19-rc1&dt=2
This will show the diffstat only, but then if I click on any of the
files for more details, the "diffstat only" mode persists. The user
would then need to know to change to "unified" in the dropdown on the
right to see actual diff contents.
It's not a bug per se, just wondering if we can improve the user experience.
Best,
--
Konstantin Ryabitsev
Linux Foundation Collab Projects
Montr?al, Qu?bec
next prev parent reply other threads:[~2014-12-29 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:40 mricon
2014-12-24 2:27 ` Jason
2014-12-24 2:30 ` Jason
2014-12-29 20:09 ` mricon [this message]
2014-12-29 22:27 ` [PATCH] ui-diff: don't link to single file diff stat john
2014-12-30 9:09 ` Jason
2014-12-30 14:53 ` mricon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A1B513.2000304@kernel.org \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).