From mboxrd@z Thu Jan  1 00:00:00 1970
From: tim.nordell at logicpd.com (Tim Nordell)
Date: Mon, 29 Feb 2016 14:48:15 -0600
Subject: [PATCH] ui-diff: Add configuration option to limit number of files
In-Reply-To: <20160228123848.GX1766@serenity.lan>
References: <1456520242-17804-1-git-send-email-tim.nordell@logicpd.com>
 <20160228123848.GX1766@serenity.lan>
Message-ID: <56D4AE8F.9040402@logicpd.com>

On 02/28/16 06:38, John Keeping wrote:
> I wonder if people will miss the fact that the diff stat has been
> truncated.  Would it be better to just drop the entire thing if there
> are too many changed files and replace it with something like:
>
> 	This diff is really big, are you sure you want to see it?
>
> and provide a link that bypasses this limit?
>

Good idea.  What if the diffstat is truncated, and rather than showing 
any diffs, it shows the message above?  It's still sometimes useful to 
see a snippet of what changed even if it's huge.  I suppose maybe the 
"forced" view could be a link to downloading the patch locally?

There are circumstances in which I really don't want an HTML view of the 
full changeset to ever be rendered to someone remotely.  An extreme 
example of this is when the kernel tree was introduced (commit tagged 
v2.6.12-rc2 in any CGIT hosted kernel repo).  I won't link it here, but 
it takes well over 100 seconds to generate on kernel.org's server, and 
content-wise is well over 300MiB since it contains essentially the 
entire source code of kernel v2.6.12-rc2 in HTML form since it was the 
introduction commit to the kernel.

- Tim