List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH] blame: add a link to the parent commit
@ 2022-02-13 15:29 John Keeping
  0 siblings, 0 replies; only message in thread
From: John Keeping @ 2022-02-13 15:29 UTC (permalink / raw)
  To: cgit; +Cc: John Keeping, Alejandro Colomar

When walking through the history, it is useful to quickly see the same
file at the previous revision, so add a link to do this.

It would be nice to link to the correct line with an additional
fragment, but this requires significantly more work so it can be done as
an enhancement later.  (ent->s_lno is mostly the right thing, but it is
the line number in the post-image of the target commit whereas the link
is to the parent of that commit, i.e. the pre-image of the target.)

Suggested-by: Alejandro Colomar <>
Signed-off-by: John Keeping <>
 ui-blame.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/ui-blame.c b/ui-blame.c
index 03136f7..3b0bcad 100644
--- a/ui-blame.c
+++ b/ui-blame.c
@@ -54,6 +54,15 @@ static void emit_blame_entry_hash(struct blame_entry *ent)
+	if (!parse_commit(suspect->commit) && suspect->commit->parents) {
+		struct commit *parent = suspect->commit->parents->item;
+		html(" ");
+		cgit_blame_link("^", "Blame the previous revision", NULL,
+				ctx.qry.head, oid_to_hex(&parent->object.oid),
+				suspect->path);
+	}
 	while (line++ < ent->num_lines)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-13 15:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 15:29 [PATCH] blame: add a link to the parent commit John Keeping

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).