From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) by inbox.vuxu.org (Postfix) with ESMTP id 824B426B11 for ; Sun, 4 Aug 2024 08:17:37 +0200 (CEST) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id abcb5644; Sun, 4 Aug 2024 06:17:25 +0000 (UTC) Received: from forward500b.mail.yandex.net (forward500b.mail.yandex.net [2a02:6b8:c02:900:1:45:d181:d500]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 432c27a4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 4 Aug 2024 06:17:24 +0000 (UTC) Received: from mail-nwsmtp-smtp-production-main-91.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-91.sas.yp-c.yandex.net [IPv6:2a02:6b8:c1c:2a89:0:640:c90:0]) by forward500b.mail.yandex.net (Yandex) with ESMTPS id 63A7261031; Sun, 4 Aug 2024 09:17:23 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-91.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id LHTPb64o4iE0-3vWXDlOX; Sun, 04 Aug 2024 09:17:22 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1722752242; bh=X2na24QygNVwUT1vuC0r3Aoano+cJu5coVQVrlBqOZc=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=RY7rKBhG4kvGDnEz0V8Q045A9byDmdj8KbhZ66gRirSx5G+ZDC8PwD9AdfHLkUOnI LRGyD9wgK8aTyN7s4igIuekoc1RHWdyJ6f+oTSHgF0T0ZXR4P/RNo2YnCCKchx0Vxc zUkZLDS8h0aIsG6CizpIpF80h3FGyf8THdCqT8fA= Authentication-Results: mail-nwsmtp-smtp-production-main-91.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <65a07ff0-48b8-43d9-914e-adfc217f0858@yandex.ru> Date: Sun, 4 Aug 2024 09:17:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix error caused by missing parameter name To: Kian Kasad References: <1BAC615F-471C-42B2-AABF-32A8D0A4F758@kasad.com> <20240804031857.40601-1-kian@kasad.com> Content-Language: en-US Cc: cgit@lists.zx2c4.com From: =?UTF-8?B?0JTQtdC90LjRgSDQn9GA0L7QvdC40L0=?= In-Reply-To: <20240804031857.40601-1-kian@kasad.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" Hi, Don't you like to use __attribute__((unused)) for marking a parameter when such a need comes up? 04.08.2024 06:18, Kian Kasad пишет: > This fixes an error which was introduced by > 2f50b47c72cbc4270bbd12ae7f520486d5f42736. Git added a new argument to > config_fn_t, and it was added to gitconfig_config(), but not named. This > causes compile warnings/errors. This commit fixes that by naming the new > parameter. > --- > scan-tree.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scan-tree.c b/scan-tree.c > index 84da86e..d4fecd8 100644 > --- a/scan-tree.c > +++ b/scan-tree.c > @@ -54,7 +54,8 @@ static void scan_tree_repo_config(const char *name, const char *value) > config_fn(repo, name, value); > } > > -static int gitconfig_config(const char *key, const char *value, const struct config_context *, void *cb) > +static int gitconfig_config(const char *key, const char *value, > + const struct config_context *UNUSED, void *cb) > { > const char *name; >