* [PATCH] ui-snapshot: filter permitted snapshot requests
@ 2018-03-31 14:26 john
0 siblings, 0 replies; only message in thread
From: john @ 2018-03-31 14:26 UTC (permalink / raw)
Currently the snapshots configuration option only filters which links
are displayed, not which snapshots may be generated and downloaded.
Apply the filter to requests as well to ensure that the system policy is
enforced.
Signed-off-by: John Keeping <john at keeping.me.uk>
---
ui-snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-snapshot.c b/ui-snapshot.c
index b2d95f7..077771a 100644
--- a/ui-snapshot.c
+++ b/ui-snapshot.c
@@ -193,7 +193,7 @@ void cgit_print_snapshot(const char *head, const char *hex,
}
f = get_format(filename);
- if (!f) {
+ if (!f || !(ctx.repo->snapshots & f->bit)) {
cgit_print_error_page(400, "Bad request",
"Unsupported snapshot format: %s", filename);
return;
--
2.16.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-03-31 14:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-31 14:26 [PATCH] ui-snapshot: filter permitted snapshot requests john
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).