From: john at keeping.me.uk (John Keeping)
Subject: [PATCH v2 04/22] plain: use cgit_print_error_page() instead of html_status()
Date: Fri, 14 Aug 2015 12:47:04 +0100 [thread overview]
Message-ID: <6720f0077285f6ccdabae840f67c414de12f84f8.1439552492.git.john@keeping.me.uk> (raw)
In-Reply-To: <cover.1439552492.git.john@keeping.me.uk>
This provides a formatted error response rather than a simple HTTP
error.
Signed-off-by: John Keeping <john at keeping.me.uk>
---
ui-plain.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui-plain.c b/ui-plain.c
index 3a2cb47..0daa7bf 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -66,13 +66,13 @@ static int print_object(const unsigned char *sha1, const char *path)
type = sha1_object_info(sha1, &size);
if (type == OBJ_BAD) {
- html_status(404, "Not found", 0);
+ cgit_print_error_page(404, "Not found", "Not found");
return 0;
}
buf = read_sha1_file(sha1, &type, &size);
if (!buf) {
- html_status(404, "Not found", 0);
+ cgit_print_error_page(404, "Not found", "Not found");
return 0;
}
ctx.page.mimetype = NULL;
@@ -225,12 +225,12 @@ void cgit_print_plain(void)
rev = ctx.qry.head;
if (get_sha1(rev, sha1)) {
- html_status(404, "Not found", 0);
+ cgit_print_error_page(404, "Not found", "Not found");
return;
}
commit = lookup_commit_reference(sha1);
if (!commit || parse_commit(commit)) {
- html_status(404, "Not found", 0);
+ cgit_print_error_page(404, "Not found", "Not found");
return;
}
if (!path_items.match) {
@@ -243,7 +243,7 @@ void cgit_print_plain(void)
walk_tree_ctx.match_baselen = basedir_len(path_items.match);
read_tree_recursive(commit->tree, "", 0, 0, &paths, walk_tree, &walk_tree_ctx);
if (!walk_tree_ctx.match)
- html_status(404, "Not found", 0);
+ cgit_print_error_page(404, "Not found", "Not found");
else if (walk_tree_ctx.match == 2)
print_dir_tail();
}
--
2.5.0.466.g9af26fa
next prev parent reply other threads:[~2015-08-14 11:47 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 15:54 [PATCH 00/17] HTTP response code improvements john
2015-04-05 15:54 ` [PATCH 01/17] ui-shared: add cgit_print_error_page() function john
2015-04-07 13:23 ` Jason
2015-04-07 13:32 ` john
2015-04-07 13:36 ` Jason
2015-04-07 18:17 ` john
2015-04-05 15:54 ` [PATCH 02/17] cgit: use cgit_print_error_page() where appropriate john
2015-04-05 15:54 ` [PATCH 03/17] clone: use cgit_print_error_page() instead of html_status() john
2015-04-05 15:54 ` [PATCH 04/17] plain: " john
2015-04-05 15:54 ` [PATCH 05/17] snapshot: " john
2015-04-05 15:54 ` [PATCH 06/17] html: remove html_status() john
2015-04-05 15:54 ` [PATCH 07/17] ui-shared: add cgit_print_layout_{start,end}() john
2015-04-05 15:54 ` [PATCH 08/17] about: move layout into page functions john
2015-04-05 15:54 ` [PATCH 09/17] commit: move layout into page function john
2015-04-05 15:54 ` [PATCH 10/17] diff: move layout to " john
2015-04-05 15:54 ` [PATCH 11/17] log: move layout into " john
2015-04-05 15:54 ` [PATCH 12/17] refs: move layout to " john
2015-04-05 15:54 ` [PATCH 13/17] stats: move layout into " john
2015-04-05 15:55 ` [PATCH 14/17] summary: " john
2015-04-05 15:55 ` [PATCH 15/17] tag: " john
2015-04-05 15:55 ` [PATCH 16/17] tree: " john
2015-04-05 18:31 ` john
2015-04-05 15:55 ` [PATCH 17/17] cmd: remove "want_layout" field john
2015-04-05 16:28 ` [PATCH 00/17] HTTP response code improvements john
2015-08-14 11:47 ` [PATCH v2 00/22] HTTP status " john
2015-08-14 11:47 ` [PATCH v2 01/22] ui-shared: add cgit_print_error_page() function john
2015-08-14 11:47 ` [PATCH v2 02/22] cgit: use cgit_print_error_page() where appropriate john
2015-08-14 11:47 ` [PATCH v2 03/22] clone: use cgit_print_error_page() instead of html_status() john
2015-08-14 11:47 ` john [this message]
2015-08-14 11:47 ` [PATCH v2 05/22] snapshot: " john
2015-08-14 11:47 ` [PATCH v2 06/22] blob: use cgit_print_error_page() to add HTTP headers john
2015-08-14 11:47 ` [PATCH v2 07/22] patch: use cgit_print_error_page() for HTTP status codes john
2015-08-14 11:47 ` [PATCH v2 08/22] snapshot: " john
2015-08-14 11:47 ` [PATCH v2 09/22] snapshot: don't reimplement cgit_print_error_page() john
2015-08-14 11:47 ` [PATCH v2 10/22] html: remove html_status() john
2015-08-14 11:47 ` [PATCH v2 11/22] ui-shared: add cgit_print_layout_{start,end}() john
2015-08-14 11:47 ` [PATCH v2 12/22] about: move layout into page functions john
2015-08-14 11:47 ` [PATCH v2 13/22] commit: move layout into page function john
2015-08-14 11:47 ` [PATCH v2 14/22] diff: move layout to " john
2015-08-14 11:47 ` [PATCH v2 15/22] log: move layout into " john
2015-08-14 11:47 ` [PATCH v2 16/22] refs: move layout to " john
2015-08-14 11:47 ` [PATCH v2 17/22] stats: move layout into " john
2015-08-14 11:47 ` [PATCH v2 18/22] summary: " john
2015-08-14 11:47 ` [PATCH v2 19/22] tag: " john
2015-08-14 11:47 ` [PATCH v2 20/22] tree: " john
2015-08-14 11:47 ` [PATCH v2 21/22] cmd: remove "want_layout" field john
2015-08-14 11:47 ` [PATCH v2 22/22] ui-shared: cache errors for "dynamic TTL" john
2015-08-14 12:17 ` [PATCH v2 00/22] HTTP status code improvements nicolas.dely
2015-08-14 13:56 ` Jason
2015-08-14 14:20 ` john
2015-08-14 14:24 ` list
2015-08-14 14:40 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6720f0077285f6ccdabae840f67c414de12f84f8.1439552492.git.john@keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).