From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy at warmcat.com (Andy Green) Date: Thu, 28 Jun 2018 07:38:45 +0800 Subject: [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI In-Reply-To: References: <153001215740.12484.13344875445662026876.stgit@mail.warmcat.com> <153001234496.12484.8630216246879475297.stgit@mail.warmcat.com> <768f5fe3-f82c-2244-8627-adf8f6894340@warmcat.com> Message-ID: <77e8a94f-5cb2-1dd3-1dcb-f5c9f69b5e57@warmcat.com> On 06/28/2018 07:30 AM, Jason A. Donenfeld wrote: > On Thu, Jun 28, 2018 at 1:24 AM Andy Green wrote: >> Can you help me understand what is "clearly superior" and "right way" >> about the [...] menu in github? >> >> Since you seem to be asking me to implement it? >> >> What put me off it was there's only one useful option on it, and it >> requires and extra click. > > I think we should have all three of github's options -- copying the > range, copying a permalink to it, and a simple link to git blame. If > you think that's too arduous and only really care about copying, then I do care about general alignment with github. I want to replace github with this as far as it goes. > instead of [...] in the menu you can just put ? (or whatever other > glyph) as a small icon inside the range, as opposed to a large > slow-fading side link. Though, I still think the menu is better than > ?, because with ? it's still unclear what precisely is being copied. That's true... I used it the other day and even I got the impression it would copy the highlit region. OK I will look at the whole burger menu thing. -Andy > Jason >