List for cgit developers and users
 help / color / Atom feed
* [PATCH v2] ui-commit: show subject in page title
@ 2020-02-23 18:52 june
  2020-02-26 12:21 ` actionmystique
  0 siblings, 1 reply; 5+ messages in thread
From: june @ 2020-02-23 18:52 UTC (permalink / raw)


Signed-off-by: C. McEnroe <june at causal.agency>
---

With Signed-off-by.

 ui-commit.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui-commit.c b/ui-commit.c
index 9a47b54..ac3ca01 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -43,6 +43,7 @@ void cgit_print_commit(char *hex, const char *prefix)
 
 	load_ref_decorations(NULL, DECORATE_FULL_REFS);
 
+	ctx.page.title = fmtalloc("%s - %s", info->subject, ctx.page.title);
 	cgit_print_layout_start();
 	cgit_print_diff_ctrls();
 	html("<table summary='commit info' class='commit-info'>\n");
-- 
2.25.0



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] ui-commit: show subject in page title
  2020-02-23 18:52 [PATCH v2] ui-commit: show subject in page title june
@ 2020-02-26 12:21 ` actionmystique
  2020-02-27  0:50   ` june
  0 siblings, 1 reply; 5+ messages in thread
From: actionmystique @ 2020-02-26 12:21 UTC (permalink / raw)


I have implemented this patch on my website (https://git.sdxlive.com/)
over the latest commit of master branch (1.2.2-2-gfde897b) & restarted
uwsgi.
I use git 1:2.25.1-1~ppa0~ubuntu20.04.1 although I don't think this
could interfere.

In /etc/cgitrc, the following relevant variables are set:
- root-title=...
- root-desc=...
In each repo cgitrc, the following relevant variable is set:
- name=... (<repository name>)

However, unless I'm missing something, I don't see any difference in
any page title: they all keep the format "index :<repository name>".

Is there a special variable which needs to be set?
-- 
Jean-Christophe


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] ui-commit: show subject in page title
  2020-02-26 12:21 ` actionmystique
@ 2020-02-27  0:50   ` june
  2020-02-27 10:07     ` actionmystique
  0 siblings, 1 reply; 5+ messages in thread
From: june @ 2020-02-27  0:50 UTC (permalink / raw)



> On Feb 26, 2020, at 07:21, jean-christophe manciot <actionmystique at gmail.com> wrote:
> 
> I have implemented this patch on my website (https://git.sdxlive.com/)
> over the latest commit of master branch (1.2.2-2-gfde897b) & restarted
> uwsgi.

> However, unless I'm missing something, I don't see any difference in
> any page title: they all keep the format "index :<repository name>?.

The title of this page, for example:
<https://git.sdxlive.com/DR/commit/?id=7775e84b3c0debcd68ab40ed4add13db2bbdfee3>
begins with the subject line of the commit,
"Debian/logs/packages.Debian.log".


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] ui-commit: show subject in page title
  2020-02-27  0:50   ` june
@ 2020-02-27 10:07     ` actionmystique
  2020-02-27 10:13       ` june
  0 siblings, 1 reply; 5+ messages in thread
From: actionmystique @ 2020-02-27 10:07 UTC (permalink / raw)


I can see "Debian/logs/packages.Debian.log" in the middle of the page
(as without the patch), but "index : Debian Bullseye Repository" on
the right side of the icon.
Either we have a different definition of "page title", or something is
different in your environment that must explain why you can see a
different page title.
Maybe a different browser, browser version, OS, ...

I have attached a screenshot of the page browsed with chrome
80.0.3987.122 (Official Build) (64-bit) on Ubuntu. focal
-- 
Jean-Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: show subject in page title.png
Type: image/png
Size: 281246 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20200227/1b92ff51/attachment-0001.png>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] ui-commit: show subject in page title
  2020-02-27 10:07     ` actionmystique
@ 2020-02-27 10:13       ` june
  0 siblings, 0 replies; 5+ messages in thread
From: june @ 2020-02-27 10:13 UTC (permalink / raw)



> On Feb 27, 2020, at 05:07, jean-christophe manciot <actionmystique at gmail.com> wrote:
> 
> I can see "Debian/logs/packages.Debian.log" in the middle of the page
> (as without the patch), but "index : Debian Bullseye Repository" on
> the right side of the icon.
> Either we have a different definition of "page title", or something is
> different in your environment that must explain why you can see a
> different page title.

Yes, I mean the HTML <title> element displayed in the browser tab
or window title.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-23 18:52 [PATCH v2] ui-commit: show subject in page title june
2020-02-26 12:21 ` actionmystique
2020-02-27  0:50   ` june
2020-02-27 10:07     ` actionmystique
2020-02-27 10:13       ` june

List for cgit developers and users

Archives are clonable: git clone --mirror http://inbox.vuxu.org/cgit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git