From: smithj4 at bnl.gov (Jason A. Smith)
Subject: [PATCH 0/3] Add support for git's mailmap.
Date: Thu, 2 Nov 2017 16:48:08 -0400 [thread overview]
Message-ID: <7da6b0ad-400c-fca2-16c9-fcd9fc6d9e91@bnl.gov> (raw)
In-Reply-To: <20171028113646.GG2393@john.keeping.me.uk>
Hi John,
I always thought that by going through the trouble of collecting the
duplicate email addresses and creating the .mailmap file that you wanted
this coalescing behavior.
Personally, I don't really want to have to remember everyone's old email
address and variation of their name that they might have used several
years ago to push a commit. I don't really care what email & name they
used a long time ago, I am more interested in just knowing who made the
commit, which is why the .mailmap coalesces all of their old identities
into their current one for display.
If people don't need or want this coalescing behavior and want to see
each individual identity then they don't need to make the .mailmap file
to begin with.
Just my opinion on .mailmap.
~Jason
On 10/28/2017 07:36 AM, John Keeping wrote:
> On Tue, Oct 24, 2017 at 10:55:21AM -0400, Jason A. Smith wrote:
>> Seeing a lot of recent activity I checked the upstream and see that the
>> patch I first submitted over a year ago has still not been merged. I
>> already had to rebase it once several months ago to fix conflicts, I
>> don't want to have to do that again. Is there something wrong with this
>> patch? Please let me know so I can fix it.
>
> I've taken another look at this patch and one thing that stands out is
> that we end up inserting code to map users in a lot of different places.
> I haven't audited the code, but after the final patch, is there anywhere
> that calls cgit_parse_commit() and doesn't go on to map the users?
> (Even if not all callers do map the user, can we push cgit_map_user()
> into cgit_parse_commit() and use a flag parameter to enable it?)
>
> But I think that points to a deeper philosophical question of whether we
> should be mapping the user in all cases (and I suspect this is why the
> patch has sat on the list for so long - there are arguments in both
> directions).
>
> As I understand it, mailmap was originally introduced so that
> git-shortlog would coalesce commits from the same author but with
> different email addresses. When using the git command, mailmap is
> enabled by default for git-shortlog and git-blame but not for git-log,
> git-show, and other commands that print commits.
>
> Extending this to CGit, it seems that there's a clear argument for
> enabling mailmap in ui-stats and possibly the new ui-blame, but when we
> print a commit in ui-commit or ui-log is it always correct to apply the
> mailmap or should we show the commit headers as-is?
>
> It would be interesting to know what others on the list think about
> this. If there isn't a consensus then we may want a new config option
> to allow this to be enabled according to the preferences of individual
> sites.
>
next prev parent reply other threads:[~2017-11-02 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 16:18 smithj4
2017-10-24 14:55 ` smithj4
2017-10-28 11:36 ` john
2017-11-02 20:48 ` smithj4 [this message]
2017-11-02 22:54 ` i
2017-11-05 12:25 ` john
2017-02-25 16:12 smithj4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da6b0ad-400c-fca2-16c9-fcd9fc6d9e91@bnl.gov \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).