List for cgit developers and users
 help / color / mirror / Atom feed
From: jim at meyering.net (Jim Meyering)
Subject: avoid stack-smash when processing unusual commit
Date: Sat, 29 Sep 2012 21:35:59 +0200	[thread overview]
Message-ID: <87fw60vcyo.fsf@rho.meyering.net> (raw)
In-Reply-To: <877gul59lo.fsf@rho.meyering.net> (Jim Meyering's message of "Tue, 03 Jul 2012 14:10:11 +0200")

Jim Meyering wrote:
> Resending, now that the list is functioning again.
> FTR, I also sent to hjemli at gmail.com (no reply) and finally
> resorted to filing a BZ: http://bugzilla.redhat.com/820733
>
> Jim Meyering wrote:
>> This started when I noticed some cgit segfaults on savannah.gnu.org.
>> Finding the offending URL/commit and then constructing a stand-alone
>> reproducer were far more time-consuming than writing the actual patch.
>>
>> The problem arises with a commit like this, in which the user name
>> part of the "Author" field is empty:
>>
>>     $ git log -1
>>     commit 6f3f41d73393278f3ede68a2cb1e7a2a23fa3421
>>     Author: <T at h.or>
>>     Date:   Mon Apr 23 22:29:16 2012 +0200

Jason,
Thanks for continuing cgit maintenance.
Here's a patch I wrote months ago.
The patch is tiny, compared to the analysis, but the analysis
took enough effort that I've included it in the commit log.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: k
URL: <http://hjemli.net/pipermail/cgit/attachments/20120929/9f23d9b2/attachment.ksh>


  reply	other threads:[~2012-09-29 19:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8762cp9rq0.fsf@rho.meyering.net>
2012-07-03 12:10 ` jim
2012-09-29 19:35   ` jim [this message]
2012-09-30 17:34     ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw60vcyo.fsf@rho.meyering.net \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).