Subject: [PATCH] Return "404 Not found" if a repo doesn't exist (any more).
Date: Sat, 01 Dec 2012 23:02:17 +0100 [thread overview]
Message-ID: <87sj7pa0t2.fsf@topper.koldfront.dk> (raw)
If a repository disappears, cgit says "No repositories found" and
returns "200 OK" [to the webcrawler] for pages referring to, say,
commits in the, now, missing repository.
This, slightly awkward, patch makes it return "404 Not found" in this
case. There is probably a better way to do this.
---
ui-repolist.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/ui-repolist.c b/ui-repolist.c
index dead1bf..ca65d44 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -247,6 +247,17 @@ void cgit_print_repolist()
if (ctx.cfg.enable_index_links)
columns++;
+ for (i=0; i<cgit_repolist.count; i++) {
+ if (!(is_match(&cgit_repolist.repos[i]) && is_in_url(&cgit_repolist.repos[i])))
+ continue;
+ hits++;
+ }
+
+ if (!hits) {
+ ctx.page.status = 404;
+ ctx.page.statusmsg = "Not found";
+ }
+
ctx.page.title = ctx.cfg.root_title;
cgit_print_http_headers(&ctx);
cgit_print_docstart(&ctx);
--
1.7.2.5
--
"Tell them to give it to Donovan." Adam Sj?gren
asjo at koldfront.dk
next reply other threads:[~2012-12-01 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 22:02 [this message]
2013-02-01 11:58 ` Jason
2013-02-01 17:48 `
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj7pa0t2.fsf@topper.koldfront.dk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).