cgit-1.2.3: Undefined symbols for architecture x86_64: "_memrchr"

cgit-1.2.3: Undefined symbols for architecture x86_64: "_memrchr"

[Eric F (iEFdev)]

Hi,

I was about to install cgit the other day, and thought I also should update the
“Portfile” (MacPorts) to the latest version - but I ran into this build error:

    :info:build Undefined symbols for architecture x86_64:
    :info:build   "_memrchr", referenced from:
    :info:build       _cgit_set_title_from_path in ui-shared.o
    :info:build ld: symbol(s) not found for architecture x86_64
—

I made a ticket report for that, and was later asked to report this to the
developers (ie you).

Last part of the `main.log`:

```
:info:build /usr/bin/clang -arch x86_64   -g -O2 -Wall -I. -DPRECOMPOSE_UNICODE
-DPROTECT_HFS_DEFAULT=1 -I/usr/local/include -DGIT_HOST_CPU="\"x86_64\""
-I/opt/local/include -DNO_CURL -DNO_OPENSSL -DUSE_ST_TIMESPEC -DNO_GETTEXT
-DSHA1_APPLE -DSHA256_BLK -DSHA1_MAX_BLOCK_SIZE="1024L*1024L*1024L"
-DHAVE_DEV_TTY -DHAVE_BSD_SYSCTL -DHAVE_GETDELIM -DHAVE_NS_GET_EXECUTABLE_PATH
-DAPPLE_COMMON_CRYPTO -DFREAD_READS_DIRECTORIES -DCOMMON_DIGEST_FOR_OPENSSL
-DNO_MEMMEM -Icompat/regex -DSHELL_PATH='"/bin/sh"' -DPAGER_ENV='"LESS=FRX
LV=-c"' -o ../cgit   -L/usr/local/lib -L/opt/local/lib ../cgit.o ../cache.o
../cmd.o ../configfile.o ../filter.o ../html.o ../parsing.o ../scan-tree.o
../shared.o ../ui-atom.o ../ui-blame.o ../ui-blob.o ../ui-clone.o ../ui-commit.o
../ui-diff.o ../ui-log.o ../ui-patch.o ../ui-plain.o ../ui-refs.o
../ui-repolist.o ../ui-shared.o ../ui-snapshot.o ../ui-ssdiff.o ../ui-stats.o
../ui-summary.o ../ui-tag.o ../ui-tree.o common-main.o libgit.a xdiff/lib.a  -lz
 -liconv
:info:build Undefined symbols for architecture x86_64:
:info:build   "_memrchr", referenced from:
:info:build       _cgit_set_title_from_path in ui-shared.o
:info:build ld: symbol(s) not found for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see
invocation)
:info:build ../cgit.mk:133: recipe for target '../cgit' failed
:info:build make[1]: *** [../cgit] Error 1
:info:build make[1]: Leaving directory
'/opt/local/var/macports/build/_opt_ports_dev_www_cgit/cgit/work/cgit-1.2.3/git'
:info:build Makefile:76: recipe for target 'cgit' failed
:info:build make: *** [cgit] Error 2
:info:build make: Leaving directory
'/opt/local/var/macports/build/_opt_ports_dev_www_cgit/cgit/work/cgit-1.2.3'
:info:build Command failed:  cd
"/opt/local/var/macports/build/_opt_ports_dev_www_cgit/cgit/work/cgit-1.2.3" &&
/usr/local/bin/make -j5 -w all prefix=/opt/local CC="/usr/bin/clang -arch
x86_64" NO_GETTEXT=1 NO_LUA=1 V=1
```

Ticket: https://trac.macports.org/ticket/60967
Log:    https://trac.macports.org/attachment/ticket/60967/cgit-1.2.3_main.log


// [OS X/macOS](https://ports.macports.org/port/cgit/)
// current version v1.2.1
—

Thanks.

Best regards,
 · Eric

Re: cgit-1.2.3: Undefined symbols for architecture x86_64: "_memrchr"

[Markus Mayer]

I submitted a patch for this a month or two ago, but it doesn't seem
to be making it to the mailing list for reasons unknown. I even tried
sending it twice. Do dice.

Regards,
-Markus


On Sat, 8 Aug 2020 at 10:20, Eric F (iEFdev) <eric@iefdev.se> wrote:
>
> Hi,
>
> I was about to install cgit the other day, and thought I also should update the
> “Portfile” (MacPorts) to the latest version - but I ran into this build error:
>
>     :info:build Undefined symbols for architecture x86_64:
>     :info:build   "_memrchr", referenced from:
>     :info:build       _cgit_set_title_from_path in ui-shared.o
>     :info:build ld: symbol(s) not found for architecture x86_64
> —
>
> I made a ticket report for that, and was later asked to report this to the
> developers (ie you).
>
> Last part of the `main.log`:
>
> ```
> :info:build /usr/bin/clang -arch x86_64   -g -O2 -Wall -I. -DPRECOMPOSE_UNICODE
> -DPROTECT_HFS_DEFAULT=1 -I/usr/local/include -DGIT_HOST_CPU="\"x86_64\""
> -I/opt/local/include -DNO_CURL -DNO_OPENSSL -DUSE_ST_TIMESPEC -DNO_GETTEXT
> -DSHA1_APPLE -DSHA256_BLK -DSHA1_MAX_BLOCK_SIZE="1024L*1024L*1024L"
> -DHAVE_DEV_TTY -DHAVE_BSD_SYSCTL -DHAVE_GETDELIM -DHAVE_NS_GET_EXECUTABLE_PATH
> -DAPPLE_COMMON_CRYPTO -DFREAD_READS_DIRECTORIES -DCOMMON_DIGEST_FOR_OPENSSL
> -DNO_MEMMEM -Icompat/regex -DSHELL_PATH='"/bin/sh"' -DPAGER_ENV='"LESS=FRX
> LV=-c"' -o ../cgit   -L/usr/local/lib -L/opt/local/lib ../cgit.o ../cache.o
> ../cmd.o ../configfile.o ../filter.o ../html.o ../parsing.o ../scan-tree.o
> ../shared.o ../ui-atom.o ../ui-blame.o ../ui-blob.o ../ui-clone.o ../ui-commit.o
> ../ui-diff.o ../ui-log.o ../ui-patch.o ../ui-plain.o ../ui-refs.o
> ../ui-repolist.o ../ui-shared.o ../ui-snapshot.o ../ui-ssdiff.o ../ui-stats.o
> ../ui-summary.o ../ui-tag.o ../ui-tree.o common-main.o libgit.a xdiff/lib.a  -lz
>  -liconv
> :info:build Undefined symbols for architecture x86_64:
> :info:build   "_memrchr", referenced from:
> :info:build       _cgit_set_title_from_path in ui-shared.o
> :info:build ld: symbol(s) not found for architecture x86_64
> :info:build clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> :info:build ../cgit.mk:133: recipe for target '../cgit' failed
> :info:build make[1]: *** [../cgit] Error 1
> :info:build make[1]: Leaving directory
> '/opt/local/var/macports/build/_opt_ports_dev_www_cgit/cgit/work/cgit-1.2.3/git'
> :info:build Makefile:76: recipe for target 'cgit' failed
> :info:build make: *** [cgit] Error 2
> :info:build make: Leaving directory
> '/opt/local/var/macports/build/_opt_ports_dev_www_cgit/cgit/work/cgit-1.2.3'
> :info:build Command failed:  cd
> "/opt/local/var/macports/build/_opt_ports_dev_www_cgit/cgit/work/cgit-1.2.3" &&
> /usr/local/bin/make -j5 -w all prefix=/opt/local CC="/usr/bin/clang -arch
> x86_64" NO_GETTEXT=1 NO_LUA=1 V=1
> ```
>
> Ticket: https://trac.macports.org/ticket/60967
> Log:    https://trac.macports.org/attachment/ticket/60967/cgit-1.2.3_main.log
>
>
> // [OS X/macOS](https://ports.macports.org/port/cgit/)
> // current version v1.2.1
> —
>
> Thanks.
>
> Best regards,
>  · Eric

Re: cgit-1.2.3: Undefined symbols for architecture x86_64: "_memrchr"

[Eric F (iEFdev)]

Hi Markus,

Thank you so much for the fast response – and thanks for the patch you sent in
the other mail:
  - https://lists.zx2c4.com/pipermail/cgit/2020-August/004506.html

I'm all about to hit the bed now, but I'll try this one soon and will report
back if it worked here as well.

Thanks again!

Best,
 · Eric



On 8/8/20 20:07 , Markus Mayer wrote:
> I submitted a patch for this a month or two ago, but it doesn't seem
> to be making it to the mailing list for reasons unknown. I even tried
> sending it twice. Do dice.
> 
> Regards,
> -Markus

Re: cgit-1.2.3: Undefined symbols for architecture x86_64: "_memrchr"

[Eric F (iEFdev)]

 Hi,

Just wanted to report back that the patch worked here as well.
I have tested it, and it built fine now without errors..

Thank you Markus!

Best,
 · Eric


On 8/8/20 20:28 , Eric F (iEFdev) wrote:
> Hi Markus,
>
> Thank you so much for the fast response – and thanks for the patch you sent in
> the other mail:
>   - https://lists.zx2c4.com/pipermail/cgit/2020-August/004506.html
>
> I'm all about to hit the bed now, but I'll try this one soon and will report
> back if it worked here as well.
>
> Thanks again!
>
> Best,
>  · Eric
>
>
> On 8/8/20 20:07 , Markus Mayer wrote:
>> I submitted a patch for this a month or two ago, but it doesn't seem
>> to be making it to the mailing list for reasons unknown. I even tried
>> sending it twice. Do dice.
>>
>> Regards,
>> -Markus