From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) by inbox.vuxu.org (Postfix) with ESMTP id 0DC4621FE2 for ; Sun, 14 Apr 2024 23:57:04 +0200 (CEST) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 27c2c988; Sun, 14 Apr 2024 21:56:52 +0000 (UTC) Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [2a01:e0c:1:1599::15]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id a40602d3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 14 Apr 2024 21:56:51 +0000 (UTC) Received: from [IPV6:2a01:e34:ec1e:c710:2e7c:5d10:e9a0:d944] (unknown [IPv6:2a01:e34:ec1e:c710:2e7c:5d10:e9a0:d944]) (Authenticated sender: lagiraudiere@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id BE96C78032A; Sun, 14 Apr 2024 23:56:48 +0200 (CEST) Message-ID: <9fa56309-2907-4d01-a811-f438189dee8d@free.fr> Date: Sun, 14 Apr 2024 23:56:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Enhancement request : ui-blob: Make the target line of a link, visually identifiable. To: Christian Hesse Cc: cgit@lists.zx2c4.com References: <5e2ed4ad-256b-40cf-bf40-68bf67336b8c@free.fr> <20240410152938.1a3f53e3@leda.eworm.net> From: =?UTF-8?B?TG/Dr2M=?= Content-Language: fr-FR, en-US In-Reply-To: <20240410152938.1a3f53e3@leda.eworm.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" Le 10/04/2024 à 15:29, Christian Hesse a écrit : > Loïc on Sat, 2024/02/03 18:20: >> Hi all, >> >> When I create a reference to a precise line in a file (for instance a >> hyperlink to "https://git.zx2c4.com/cgit/tree/cgit.css#n321" ), I miss a >> visual feedback, on the line I want to highlight. >> >> To implement this feature, I suggest to add a curved arrow ahead of the >> line number. >> That could be done by adding the following stylesheet to cgit.css >> >>    div#cgit table.blob td.linenumbers a:target:before {color: >> red;content: "\2BA9";} > I really like that functionality, though the curved arrow is really > inconspicuous. Wondering if something like "large red circle" (or "large > black circle", colored in red) would be a better match... Unfortunately, the size is constrained by the underlying font. Initially, I searched for a character like "BLACK RIGHT POINTING BACKHAND INDEX" or "LINK SYMBOL", but it was even smaller. I also tried to change the font size but it didn't produce a good result either since it changes the line height. So, feel free to change the mark to something more convenient. The "large black circle" (\2B24), colored in red seems fine. (I prefer the "BLACK LARGE CIRCLE" colored in red over the "LARGE RED CIRCLE" because it makes it easier to change the color)