[cgit] a + in the path

[cgit] a + in the path

[hjemli]

[Added cgit list to CC]

On Sat, Mar 5, 2011 at 14:44, Alejandro Mery <amery at geeks.cl> wrote:
> Hi,
>
> I'm running 0.8.3.4 at http://git.opensde.net and everything is going
> great except the paths with a + on them.... like
> http://git.opensde.net/opensde/package-nopast/tree/gtk+

I've tested this on my local setup, and all of the following urls
works as expected:
* http://localhost/git/test/tmp/tree/a+b
* http://localhost/git/test/tmp/tree/gtk+
* http://localhost/git/test/tmp/tree/gtk+/foo

There' also some tests for this in tests/t0104-tree.sh.

Do you by any change use url rewriting?

--
larsh

[cgit] a + in the path

[amery]

On Thu, Mar 10, 2011 at 18:54, Lars Hjemli <hjemli at gmail.com> wrote:
> [Added cgit list to CC]
>
> On Sat, Mar 5, 2011 at 14:44, Alejandro Mery <amery at geeks.cl> wrote:
>> Hi,
>>
>> I'm running 0.8.3.4 at http://git.opensde.net and everything is going
>> great except the paths with a + on them.... like
>> http://git.opensde.net/opensde/package-nopast/tree/gtk+
>
> I've tested this on my local setup, and all of the following urls
> works as expected:
> * http://localhost/git/test/tmp/tree/a+b
> * http://localhost/git/test/tmp/tree/gtk+
> * http://localhost/git/test/tmp/tree/gtk+/foo
>
> There' also some tests for this in tests/t0104-tree.sh.
>
> Do you by any change use url rewriting?

yes, there is one in nginx:
rewrite	^ /cgit.cgi$request_uri;

doing
export PATH_INFO=$(echo "$PATH_INFO" | sed -e 's,%2b,+,g')

in cgit.cgi did the trick. not sure if it's the browser or nginx who's
translating + to %2b

Thanks! :-)