From mboxrd@z Thu Jan 1 00:00:00 1970 From: hjemli at gmail.com (Lars Hjemli) Date: Thu, 10 Mar 2011 18:29:49 +0100 Subject: [PATCH 4/5] fix two encoding bugs In-Reply-To: <1299773004-27380-4-git-send-email-plenz@cis.fu-berlin.de> References: <1299773004-27380-1-git-send-email-plenz@cis.fu-berlin.de> <1299773004-27380-4-git-send-email-plenz@cis.fu-berlin.de> Message-ID: On Thu, Mar 10, 2011 at 17:03, Julius Plenz wrote: > reencode() takes three arguments in the order (txt, from, to), opposed to > reencode_string, which will, like iconv, handle the arguments with from > and to swapped. Fix that (this makes reencode more intuitive). Oh my. Thanks for fixing this. > If src and dst encoding are equivalent, don't do any encoding. > > If no special encoding parameter is found within the commit, assume > UTF-8 and explicitly convert to PAGE_ENCODING. The change to reencode() > mentioned above avoids re-encoding a UTF-8 string to UTF-8, for example. These two changes also makes sense. Will apply. -- larsh