List for cgit developers and users
 help / color / mirror / Atom feed
From: Tobias.Bieniek at gmx.de (Tobias Bieniek)
Subject: [PATCH 1/3] Added "sort-sections" flag for the repository listing
Date: Tue, 9 Oct 2012 23:47:04 +0200	[thread overview]
Message-ID: <CABEOeTkWShCDjT9aXzWHEUkvM1m-xqWFra7HK40kNyNK2qjn+g@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9rsWq9fidR4Uw+XzcCKzLvWkeW=Q7Yss=kObTEonFR_Sg@mail.gmail.com>

>> This makes it possible to activate the enable_commit_graph,
>> enable_log_filecount and enable_log_linecount for individual
>> repositories, even if the global setting is "0" (default).
>>
>>
>> - repo->enable_commit_graph = ctx.cfg.enable_commit_graph * atoi(value);
>> + repo->enable_commit_graph = atoi(value);
>
> Was this the intended behavior before, or was this erroneously copy
> and pasted from elsewhere, and is therefore a bug? What I'm wondering
> is -- should I evaluate this as a behavior change or as a bug fix?

IMHO this should be treated as a bug fix. The settings for the
individual repos should overwrite the global settings. If I remember
correctly this is the way most other settings are handled too only
these few settings were not doing it properly.




  parent reply	other threads:[~2012-10-09 21:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 15:38 Tobias.Bieniek
2012-07-02 15:38 ` [PATCH 2/3] Added "date-order" and "topo-order" flags Tobias.Bieniek
2012-07-02 15:38 ` [PATCH 3/3] Fixed parameter parsing in repo_config() function Tobias.Bieniek
     [not found] ` <CABEOeT=yfWaqRfanCcgVYLkTa3PD8JtkfvY2NfTGxNOAO2PEFQ@mail.gmail.com>
2012-10-08 21:11   ` [PATCH 1/3] Added "sort-sections" flag for the repository listing Jason
2012-10-09 18:59     ` Tobias.Bieniek
2012-10-09 19:03       ` Jason
2012-10-09 19:10         ` Jason
2012-10-09 19:11           ` Jason
2012-10-09 21:54             ` Tobias.Bieniek
2012-10-09 22:16               ` Jason
2012-10-09 21:49           ` Tobias.Bieniek
2012-10-09 22:15             ` Jason
2012-10-09 22:26               ` Tobias.Bieniek
2012-10-13 14:24           ` Tobias.Bieniek
2012-10-09 21:47         ` Tobias.Bieniek [this message]
2012-10-09 19:12       ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABEOeTkWShCDjT9aXzWHEUkvM1m-xqWFra7HK40kNyNK2qjn+g@mail.gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).