From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tobias.Bieniek at gmx.de (Tobias Bieniek)
Date: Tue, 9 Oct 2012 23:47:04 +0200
Subject: [PATCH 1/3] Added "sort-sections" flag for the repository listing
In-Reply-To: <CAHmME9rsWq9fidR4Uw+XzcCKzLvWkeW=Q7Yss=kObTEonFR_Sg@mail.gmail.com>
References: <1341243538-15160-1-git-send-email-Tobias.Bieniek@gmx.de>
 <CABEOeT=yfWaqRfanCcgVYLkTa3PD8JtkfvY2NfTGxNOAO2PEFQ@mail.gmail.com>
 <CAHmME9qr3qO9VkGE+8QnHLdWhkoWeY8h5QJxrPBC8Qe05i7wzg@mail.gmail.com>
 <CABEOeTnhNY9GottsgogpeQ8z-ntXiUzy4qrozZT+mB+do=D6Gw@mail.gmail.com>
 <CAHmME9rsWq9fidR4Uw+XzcCKzLvWkeW=Q7Yss=kObTEonFR_Sg@mail.gmail.com>
Message-ID: <CABEOeTkWShCDjT9aXzWHEUkvM1m-xqWFra7HK40kNyNK2qjn+g@mail.gmail.com>

>> This makes it possible to activate the enable_commit_graph,
>> enable_log_filecount and enable_log_linecount for individual
>> repositories, even if the global setting is "0" (default).
>>
>>
>> - repo->enable_commit_graph = ctx.cfg.enable_commit_graph * atoi(value);
>> + repo->enable_commit_graph = atoi(value);
>
> Was this the intended behavior before, or was this erroneously copy
> and pasted from elsewhere, and is therefore a bug? What I'm wondering
> is -- should I evaluate this as a behavior change or as a bug fix?

IMHO this should be treated as a bug fix. The settings for the
individual repos should overwrite the global settings. If I remember
correctly this is the way most other settings are handled too only
these few settings were not doing it properly.