From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tobias.Bieniek at gmx.de (Tobias Bieniek)
Date: Tue, 9 Oct 2012 23:49:02 +0200
Subject: [PATCH 1/3] Added "sort-sections" flag for the repository listing
In-Reply-To: <CAHmME9q9mdHWC7K+=4FuN=qe8g+U5wa+YbE-3yo7qcm2ABB_mA@mail.gmail.com>
References: <1341243538-15160-1-git-send-email-Tobias.Bieniek@gmx.de>
 <CABEOeT=yfWaqRfanCcgVYLkTa3PD8JtkfvY2NfTGxNOAO2PEFQ@mail.gmail.com>
 <CAHmME9qr3qO9VkGE+8QnHLdWhkoWeY8h5QJxrPBC8Qe05i7wzg@mail.gmail.com>
 <CABEOeTnhNY9GottsgogpeQ8z-ntXiUzy4qrozZT+mB+do=D6Gw@mail.gmail.com>
 <CAHmME9rsWq9fidR4Uw+XzcCKzLvWkeW=Q7Yss=kObTEonFR_Sg@mail.gmail.com>
 <CAHmME9q9mdHWC7K+=4FuN=qe8g+U5wa+YbE-3yo7qcm2ABB_mA@mail.gmail.com>
Message-ID: <CABEOeTksxqPKJYYoMrSj-kHy-oCK8p3VSc15CKLqKW==OnqOPA@mail.gmail.com>

2012/10/9 Jason A. Donenfeld <Jason at zx2c4.com>:
>> + else if (!strcmp(name, "date-order"))
>> + repo->date_order = atoi(value);
>> + else if (!strcmp(name, "topo-order"))
>> + repo->topo_order = atoi(value);
>>
>> + if (date_order) {
>> + static const char *date_order_arg = "--date-order";
>> + vector_push(&vec, &date_order_arg, 0);
>> + }
>> +
>> + if (topo_order) {
>> + static const char *topo_order_arg = "--topo-order";
>> + vector_push(&vec, &topo_order_arg, 0);
>> + }
>
>
> Some quick testing of git log reveals that only date-order or
> topo-order can be specified, and if both are specified, it just rolls
> with the last one.
>
> As such, consider reworking these two options into a single option,
> similar to how the "section-sort" option does it.

Makes sense, I'll have a look at it.

>> This makes it possible to use strict commit date ordering even when
>> the commit graph flag is activated.
>
> Does this destroy the consistency of the commit graph at all? What are
> the side effects here?

We have used the strict date ordering at http://git.xcsoar.org/ for a
few months now and we did not experience any issues at all.