List for cgit developers and users
 help / color / mirror / Atom feed
From: Tobias.Bieniek at gmx.de (Tobias Bieniek)
Subject: [PATCH 1/3] Added "sort-sections" flag for the repository listing
Date: Sat, 13 Oct 2012 16:24:10 +0200	[thread overview]
Message-ID: <CABEOeTnq7sG9nCybNOYDPbohRQdaKs5B=eKFgHZxbHco-Tgyng@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9q9mdHWC7K+=4FuN=qe8g+U5wa+YbE-3yo7qcm2ABB_mA@mail.gmail.com>

2012/10/9 Jason A. Donenfeld <Jason at zx2c4.com>:
>> + else if (!strcmp(name, "date-order"))
>> + repo->date_order = atoi(value);
>> + else if (!strcmp(name, "topo-order"))
>> + repo->topo_order = atoi(value);
>>
>> + if (date_order) {
>> + static const char *date_order_arg = "--date-order";
>> + vector_push(&vec, &date_order_arg, 0);
>> + }
>> +
>> + if (topo_order) {
>> + static const char *topo_order_arg = "--topo-order";
>> + vector_push(&vec, &topo_order_arg, 0);
>> + }
>
>
> Some quick testing of git log reveals that only date-order or
> topo-order can be specified, and if both are specified, it just rolls
> with the last one.
>
> As such, consider reworking these two options into a single option,
> similar to how the "section-sort" option does it.

Hi Jason, I've reworked the ordering commit. The new flag is called
"log-order" and can have the values "date", "topo" or any other value
for the default ordering. The commits are available again in the same
repository at git://github.com/Turbo87/cgit.git

Turbo




  parent reply	other threads:[~2012-10-13 14:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 15:38 Tobias.Bieniek
2012-07-02 15:38 ` [PATCH 2/3] Added "date-order" and "topo-order" flags Tobias.Bieniek
2012-07-02 15:38 ` [PATCH 3/3] Fixed parameter parsing in repo_config() function Tobias.Bieniek
     [not found] ` <CABEOeT=yfWaqRfanCcgVYLkTa3PD8JtkfvY2NfTGxNOAO2PEFQ@mail.gmail.com>
2012-10-08 21:11   ` [PATCH 1/3] Added "sort-sections" flag for the repository listing Jason
2012-10-09 18:59     ` Tobias.Bieniek
2012-10-09 19:03       ` Jason
2012-10-09 19:10         ` Jason
2012-10-09 19:11           ` Jason
2012-10-09 21:54             ` Tobias.Bieniek
2012-10-09 22:16               ` Jason
2012-10-09 21:49           ` Tobias.Bieniek
2012-10-09 22:15             ` Jason
2012-10-09 22:26               ` Tobias.Bieniek
2012-10-13 14:24           ` Tobias.Bieniek [this message]
2012-10-09 21:47         ` Tobias.Bieniek
2012-10-09 19:12       ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABEOeTnq7sG9nCybNOYDPbohRQdaKs5B=eKFgHZxbHco-Tgyng@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).