From: rep.dot.nop at gmail.com (Bernhard Reutner-Fischer)
Subject: [PATCH] ui-repolist: Tweak max-repo-count handling
Date: Thu, 18 Jun 2015 15:48:13 +0200 [thread overview]
Message-ID: <CAC1BbcSv38vkmkK5pnt372k-gJHOMmqV=fLKUR+v-RTkO_xEYA@mail.gmail.com> (raw)
In-Reply-To: <20150618130215.GI18226@serenity.lan>
On 18 June 2015 at 15:02, John Keeping <john at keeping.me.uk> wrote:
> On Thu, Jun 18, 2015 at 02:18:32PM +0200, Bernhard Reutner-Fischer wrote:
>> A max-repo-count less than or equal to 0 now disables repository
>> pagination.
>>
>> Previously a value of 0 or smaller went into an infinite loop just
>> printing pagination links without any repo.
>
> This feels a bit fragile, in that ever use of the max_repo_count
> variable needs to check this explicitly. Would it be better to simply
> set the value to MAX_INT if the config file has a value <= 0?
Conceptually it feels wrong to use a (high) number to turn something off.
thanks,
next prev parent reply other threads:[~2015-06-18 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 12:18 rep.dot.nop
2015-06-18 13:02 ` john
2015-06-18 13:48 ` rep.dot.nop [this message]
2016-06-09 15:32 ` rep.dot.nop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC1BbcSv38vkmkK5pnt372k-gJHOMmqV=fLKUR+v-RTkO_xEYA@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).