From: sylvain at abstraction.fr (Sylvain Rabot)
Subject: Cache system
Date: Sun, 9 Oct 2016 21:47:24 +0200 [thread overview]
Message-ID: <CADjtP1HxzQbAs4aTg6-pe9=SPr5iitbg1+qWNW2bx0iJYfTixA@mail.gmail.com> (raw)
In-Reply-To: <20161009185103.GR1997@john.keeping.me.uk>
On Sun, Oct 9, 2016 at 8:51 PM, John Keeping <john at keeping.me.uk> wrote:
> On Sun, Oct 09, 2016 at 08:24:20PM +0200, Sylvain Rabot wrote:
>> As far as I understand it the cgit cache system relies only on the
>> path of a request (the PATH_INFO var to be precise).
>>
>> The cgit setup I made is not compatible with this cache system because
>> I use http for public repositories and http*s* for private ones on the
>> same machine.
>>
>> Basically with my setup, paths could collide between http and https,
>> especially the index page which lists the repositories.
>>
>> I was wondering if you could think about making the cache system rely
>> on the whole url instead of just the path.
>
> I'm not sure we can reliably receive this over the CGI interface. Even
> if we do, I don't think this change is a benefit for most users.
>
> Can't you run with separate config files for HTTP and HTTPS, using the
> "include" directive to keep everything except the cache directory the
> same?
Indeed, I did not think of that. Thank you!
--
Sylvain Rabot <sylvain at abstraction.fr>
prev parent reply other threads:[~2016-10-09 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 18:24 sylvain
2016-10-09 18:51 ` john
2016-10-09 19:47 ` sylvain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADjtP1HxzQbAs4aTg6-pe9=SPr5iitbg1+qWNW2bx0iJYfTixA@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).