From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvain at abstraction.fr (Sylvain Rabot) Date: Sun, 9 Oct 2016 21:47:24 +0200 Subject: Cache system In-Reply-To: <20161009185103.GR1997@john.keeping.me.uk> References: <20161009185103.GR1997@john.keeping.me.uk> Message-ID: On Sun, Oct 9, 2016 at 8:51 PM, John Keeping wrote: > On Sun, Oct 09, 2016 at 08:24:20PM +0200, Sylvain Rabot wrote: >> As far as I understand it the cgit cache system relies only on the >> path of a request (the PATH_INFO var to be precise). >> >> The cgit setup I made is not compatible with this cache system because >> I use http for public repositories and http*s* for private ones on the >> same machine. >> >> Basically with my setup, paths could collide between http and https, >> especially the index page which lists the repositories. >> >> I was wondering if you could think about making the cache system rely >> on the whole url instead of just the path. > > I'm not sure we can reliably receive this over the CGI interface. Even > if we do, I don't think this change is a benefit for most users. > > Can't you run with separate config files for HTTP and HTTPS, using the > "include" directive to keep everything except the cache directory the > same? Indeed, I did not think of that. Thank you! -- Sylvain Rabot