List for cgit developers and users
 help / color / mirror / Atom feed
Subject: Commit _subject_ filter, everywhere
Date: Wed, 29 Nov 2017 22:10:00 +0100	[thread overview]
Message-ID: <CAEYzJUFMf_OjdWv_V4eJovrSdEthDjcih71gsdp+zLMRK=bGgg@mail.gmail.com> (raw)

Hi Jason, all,

I got this idea to generate a link to the CI server job in front of
each commit message subject. Think small green/red boxes that are
clickable. I figure that getting the build status directly in cgit is
much more efficient than navigating the CI server itself, which
typically requires many clicks to find the build that comes out of a
given commit.

I had high hopes for the the commit-filter= setting, but found that

* commit-filter= is only run when showing a full commit, not other
places. I.e. it is applied when showing the "commit" tab, but not on
"summary", "logs" or "refs".
* commit-filter= is run twice on a commit message. Once for the
subject and once for the body. I expected only once. (Is this a bug?)

Any thoughts on if/how this use case can be supported? A separate
filter? Or simply run commit-filter= everywhere (breaking change)?

Best regards,
Bj?rn Forsman (happy cgit user)


             reply	other threads:[~2017-11-29 21:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 21:10  [this message]
2017-12-02 11:31 ` john
2017-12-02 12:33   ` 
2017-12-02 12:49     ` john
2017-12-02 14:44       ` 
2017-12-02 17:10         ` john
2017-12-02 17:14           ` 
2017-12-02 19:00             ` 

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEYzJUFMf_OjdWv_V4eJovrSdEthDjcih71gsdp+zLMRK=bGgg@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).