From: hjemli at gmail.com (Lars Hjemli)
Subject: [PATCH] add TITLE to log commit entries
Date: Sun, 18 Mar 2012 10:55:17 +0100 [thread overview]
Message-ID: <CAFXTnz40xOJann2Pnn=RKNuya01OLgUAnpHYggh7Yv815OhJwA@mail.gmail.com> (raw)
In-Reply-To: <CALXrvzA40xXy3LjzWwVYTBY=sWzkS354Zfz9diWSWCm4_iVXqA@mail.gmail.com>
On Fri, Mar 2, 2012 at 23:08, Josef wells <Josefwells at alumni.utexas.net> wrote:
> ---
> ?ui-shared.c | ? ?7 ++++++-
> ?1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/ui-shared.c b/ui-shared.c
> index 3e9282f..305342d 100644
> --- a/ui-shared.c
> +++ b/ui-shared.c
> @@ -360,7 +360,12 @@ void cgit_commit_link(char *name, const char
> *title, const char *class,
> ? ? ? ? ? ? ? ?html("ignorews=1");
> ? ? ? ? ? ? ? ?delim = "&";
> ? ? ? ?}
> - ? ? ? html("'>");
> + ? ? ? html("' ");
> + ? ? ? if (rev && strcmp(rev, ctx.qry.head)) {
> + ? ? ? ? ? ? ? html("TITLE=");
> + ? ? ? ? ? ? ? html_url_arg(rev);
> + ? ? ? }
> + ? ? ? html(">");
> ? ? ? ?html_txt(name);
> ? ? ? ?html("</a>");
> ?}
The title-attribute is already set (in repolink()) from the title
argument, i.e. the caller of cgit_commit_link() decides what title, if
any, should be set on the link.
But fwiw, I don't think showing the commit sha1 as link title is very useful.
--
larsh
prev parent reply other threads:[~2012-03-18 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 22:08 Josefwells
2012-03-14 22:03 ` cgit
2012-03-18 9:55 ` hjemli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFXTnz40xOJann2Pnn=RKNuya01OLgUAnpHYggh7Yv815OhJwA@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).