From mboxrd@z Thu Jan  1 00:00:00 1970
From: hjemli at gmail.com (Lars Hjemli)
Date: Sun, 18 Mar 2012 10:55:17 +0100
Subject: [PATCH] add TITLE to log commit entries
In-Reply-To: <CALXrvzA40xXy3LjzWwVYTBY=sWzkS354Zfz9diWSWCm4_iVXqA@mail.gmail.com>
References: <CALXrvzA40xXy3LjzWwVYTBY=sWzkS354Zfz9diWSWCm4_iVXqA@mail.gmail.com>
Message-ID: <CAFXTnz40xOJann2Pnn=RKNuya01OLgUAnpHYggh7Yv815OhJwA@mail.gmail.com>

On Fri, Mar 2, 2012 at 23:08, Josef wells <Josefwells at alumni.utexas.net> wrote:
> ---
> ?ui-shared.c | ? ?7 ++++++-
> ?1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/ui-shared.c b/ui-shared.c
> index 3e9282f..305342d 100644
> --- a/ui-shared.c
> +++ b/ui-shared.c
> @@ -360,7 +360,12 @@ void cgit_commit_link(char *name, const char
> *title, const char *class,
> ? ? ? ? ? ? ? ?html("ignorews=1");
> ? ? ? ? ? ? ? ?delim = "&amp;";
> ? ? ? ?}
> - ? ? ? html("'>");
> + ? ? ? html("' ");
> + ? ? ? if (rev && strcmp(rev, ctx.qry.head)) {
> + ? ? ? ? ? ? ? html("TITLE=");
> + ? ? ? ? ? ? ? html_url_arg(rev);
> + ? ? ? }
> + ? ? ? html(">");
> ? ? ? ?html_txt(name);
> ? ? ? ?html("</a>");
> ?}

The title-attribute is already set (in repolink()) from the title
argument, i.e. the caller of cgit_commit_link() decides what title, if
any, should be set on the link.

But fwiw, I don't think showing the commit sha1 as link title is very useful.

--
larsh