From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH 1/2] bugfix: in ssdiff, fix line number links
Date: Tue, 30 Oct 2012 10:37:20 -0600 [thread overview]
Message-ID: <CAHmME9o5hd0JNgGeJkd-FS4Zkka4ARtyO0+5FzJoQ+QF0OBiVQ@mail.gmail.com> (raw)
In-Reply-To: <1351601762-953642-2-git-send-email-plenz@cis.fu-berlin.de>
On Tue, Oct 30, 2012 at 6:56 AM, Julius Plenz <plenz at cis.fu-berlin.de> wrote:
> Previously, the id_str (i.e. the current or diffed-against commit's
> SHA1 ID) was simply concatenated to the URL. Now, prepend an "id="
> string so that the links actually point to the right blobs and thus
> the exact lines.
Looks good - nice find.
Merged into a branch until the other ssdiff patch is worked out too:
http://git.zx2c4.com/cgit/commit/?h=jp/ssdiff&id=2530fde3a7b5f0751a68839bab406a272f154bbd
next prev parent reply other threads:[~2012-10-30 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 12:56 [PATCH 0/2] side-by-side-diff fixes plenz
2012-10-30 12:56 ` [PATCH 1/2] bugfix: in ssdiff, fix line number links plenz
2012-10-30 16:37 ` Jason [this message]
2012-10-30 12:56 ` [PATCH 2/2] bugfix: make ss-diff correctly handle tab expansion plenz
2012-10-30 14:56 ` plenz
2012-10-30 16:56 ` Jason
2012-10-30 17:12 ` plenz
2012-10-30 17:25 ` Jason
2012-10-30 17:52 ` plenz
2012-11-15 0:03 ` Jason
2012-11-15 16:35 ` [PATCH v2] " plenz
2013-02-01 12:51 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9o5hd0JNgGeJkd-FS4Zkka4ARtyO0+5FzJoQ+QF0OBiVQ@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).