From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: premature exits bork cache
Date: Fri, 26 Feb 2016 13:29:21 +0100 [thread overview]
Message-ID: <CAHmME9oStUe22mDw-NRsLP9RQ9DHbS89tETB+RmN2=SQ3tmFsQ@mail.gmail.com> (raw)
Hi guys,
When caching is turned on, if we exit(0) early from a cmd, the cache
won't be properly finalized (or even sent), and we get a server error
because of blank output. I just fixed this bug with redirect:
https://git.zx2c4.com/cgit/commit/?id=e9cbdf64632fbe64d6b0c4974ac947ef954938e7
This is fine, because it's called only from 1 function (three times),
and that function then returns, so execution doesn't continue after
the redirect. It simply gives control back to the caching layer that
does things properly now.
But I noticed we have this issue with HTTP HEAD method:
https://git.zx2c4.com/cgit/tree/ui-shared.c#n695
Here we're calling exit(0). The motivation, I imagine, was that we
want to retain the same handlers, but just return the headers for the
HEAD method. Unfortunately, this borks the cache layer for the same
reasons as described above. I'm not yet sure the cleanest way to fix
this. Suggestions?
Jason
next reply other threads:[~2016-02-26 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 12:29 Jason [this message]
2016-02-26 16:09 ` john
2016-02-26 16:18 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9oStUe22mDw-NRsLP9RQ9DHbS89tETB+RmN2=SQ3tmFsQ@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).