From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH 1/2] Skip cache slot when time-to-live is zero
Date: Thu, 6 Feb 2014 20:52:46 +0100 [thread overview]
Message-ID: <CAHmME9onwk5O8QkjVUA4TJ9Q53ZjY56OR+7_ghRS+Vgr6RhQhg@mail.gmail.com> (raw)
In-Reply-To: <1391593564-10662-2-git-send-email-cgit@cryptocrack.de>
On Wed, Feb 5, 2014 at 10:46 AM, Lukas Fleischer <cgit at cryptocrack.de>wrote:
>
> /* If the cache is disabled, just generate the content */
> - if (size <= 0) {
> + if (size <= 0 || ttl == 0) {
> fn();
> return 0;
> }
Apparently we already special case ttl for < 0:
/* Check if the slot has expired */
static int is_expired(struct cache_slot *slot)
{
if (slot->ttl < 0)
return 0;
else
return slot->cache_st.st_mtime + slot->ttl * 60 <
time(NULL);
}
What should our behavior be for consistency?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140206/82d4383c/attachment.html>
next prev parent reply other threads:[~2014-02-06 19:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 9:46 [PATCH 0/2] Add an option to cache snapshots cgit
2014-02-05 9:46 ` [PATCH 1/2] Skip cache slot when time-to-live is zero cgit
2014-02-06 19:52 ` Jason [this message]
2014-02-06 21:07 ` cgit
[not found] ` <CAHmME9q805o8hczd1MW1Mw+DzJzRmE-5C9i6CB+cX2um_R=+yA@mail.gmail.com>
2014-02-08 13:41 ` Jason
2014-02-08 13:45 ` cgit
2014-02-20 18:58 ` Jason
2014-02-20 19:59 ` [PATCH] " cgit
2014-02-20 20:03 ` Jason
2014-02-20 20:07 ` cgit
2014-02-21 0:37 ` Jason
2014-02-05 9:46 ` [PATCH 2/2] Add a cache-snapshot-ttl configuration variable cgit
2014-02-05 14:44 ` Jason
2014-02-05 15:09 ` cgit
2014-02-08 13:36 ` cgit
2014-02-20 18:56 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9onwk5O8QkjVUA4TJ9Q53ZjY56OR+7_ghRS+Vgr6RhQhg@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).