From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH 0/2] Git-Config Parsing during scan-path
Date: Mon, 8 Oct 2012 23:27:56 +0200 [thread overview]
Message-ID: <CAHmME9ot-KaSUHf1W9wsfDZXJJRmZ7uBkppHbVqbcghTHgm0Vw@mail.gmail.com> (raw)
In-Reply-To: <1349645027-22007-1-git-send-email-necoro@necoro.net>
Hi Ren?,
I've merged these changes into a branch in the repo:
http://git.zx2c4.com/cgit/log/?h=rn/gitconfig
I'd like to mull over them for a few days and not to hastily merge
them into master for a couple of reasons.
- Currently the section and description tags are taken care of using
gitweb.category and gitweb.description, just fine using these two
commits in master:
http://git.zx2c4.com/cgit/commit/?id=fc9181ff3d3ebbe0159871f6a49438e60bb17f58
http://git.zx2c4.com/cgit/commit/?id=b56be4ba3a942dd1978fe4bfecd9afc35aab0027
So one set of patches or the other does duplicate some functionality.
- There are certain advantages of keeping with the gitweb.* namespace,
as it promotes compatibility and unifies a web-oriented configuration
namespace. "When things are in the gitweb area, it means they should
work with webpages that use git for data." I'm not sure I like the
idea of a general cgit namespace, and then cherry picking special
gitweb.* items.
- git_config_from_file should only be called once. This patch series
duplicates the call. Things should be unified into one callback
function.
- The two patches listed above work with the gitolite default, which is nice.
- I don't like having the uber gitolite-specific documentation in
there. It seems like a general solution would be more optimal. On the
other hand, since cgit is so commonly used alongside gitolite, we
could creep gradually in this direction, thought I don't think this
was ever Lars' intention.
What are your thoughts?
Jason
next prev parent reply other threads:[~2012-10-08 21:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 21:23
2012-10-07 21:23 ` [PATCH 1/2] Read "cgit.*" settings from gitconfig
2012-10-08 15:14 ` jamie.couture
2012-10-08 15:19 ` Jason
2012-10-08 15:24 `
2012-10-08 15:25 ` Jason
2012-10-07 21:23 ` [PATCH 2/2] Documentation for the gitconfig sourcing
2012-10-08 21:27 ` Jason [this message]
2012-10-09 9:30 ` [PATCH 0/2] Git-Config Parsing during scan-path
2012-10-09 11:40 ` Jason
2012-10-09 12:07 `
2012-10-09 12:22 ` Jason
2012-10-09 11:02 ` jamie.couture
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9ot-KaSUHf1W9wsfDZXJJRmZ7uBkppHbVqbcghTHgm0Vw@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).